Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore the missing include in debian/rules. #1706

Merged
merged 2 commits into from
May 17, 2024

Conversation

igorpeshansky
Copy link
Member

@igorpeshansky igorpeshansky commented May 14, 2024

Description

Restore the missing include in debian/rules. This undoes an accidental change from #1438, and makes the version string on Debian platforms use the codename again.

Related issue

b/340605738

How has this been tested?

Manual builds.
Before:

metric:{type:"agent.googleapis.com/agent/uptime" labels:{key:"version" value:"google-cloud-ops-agent-metrics/2.47.0-debian12"}}

After:

metric:{type:"agent.googleapis.com/agent/uptime" labels:{key:"version" value:"google-cloud-ops-agent-metrics/2.47.0-bookworm"}}

Checklist:

  • Unit tests
    • Unit tests do not apply.
    • Unit tests have been added/modified and passed for this PR.
  • Integration tests
    • Integration tests do not apply.
    • Integration tests have been added/modified and passed for this PR.
  • Documentation
    • This PR introduces no user visible changes.
    • This PR introduces user visible changes and the corresponding documentation change has been made1.
  • Minor version bump
    • This PR introduces no new features.
    • This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
    • This PR bumps the version.

Footnotes

  1. Note that this behavior was already undocumented, so no documentation changes were needed.

This undoes an accidental change from #1438, and makes the version
string on Debian platforms use the codename again.
@igorpeshansky igorpeshansky marked this pull request as ready for review May 16, 2024 16:36
@igorpeshansky igorpeshansky merged commit 2ccb8b5 into master May 17, 2024
73 of 75 checks passed
@igorpeshansky igorpeshansky deleted the igorpeshansky-debian-version-fix branch May 17, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants