Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Internal: determine distro folder for 3p tests from OS.ID #1702

Merged
merged 8 commits into from
May 23, 2024
Merged

Internal: determine distro folder for 3p tests from OS.ID #1702

merged 8 commits into from
May 23, 2024

Conversation

Subbarker
Copy link
Contributor

@Subbarker Subbarker commented May 13, 2024 •
edited by igorpeshansky

Description

Related issue

b/337016736

How has this been tested?

Checklist:

  • Unit tests
    • Unit tests do not apply.
    • Unit tests have been added/modified and passed for this PR.
  • Integration tests
    • Integration tests do not apply.
    • Integration tests have been added/modified and passed for this PR.
  • Documentation
    • This PR introduces no user visible changes.
    • This PR introduces user visible changes and the corresponding documentation change has been made.
  • Minor version bump
    • This PR introduces no new features.
    • This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
    • This PR bumps the version.

igorpeshansky
igorpeshansky approved these changes May 22, 2024
View reviewed changes
Copy link
Member

@igorpeshansky igorpeshansky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

integration_test/third_party_apps_test/main_test.go
func distroFolder(imageSpec string) (string, error) {
if gce.IsWindows(imageSpec) {
func distroFolder(vm *gce.VM) (string, error) {
if gce.IsWindows(vm.ImageSpec) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Optional] Should this eventually become gce.IsWindows(vm)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eventually, yes. Out of scope for this PR.

@Subbarker Subbarker merged commit 8193764 into master May 23, 2024
74 of 75 checks passed
@Subbarker Subbarker deleted the subbarker-distro-folder branch May 23, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igorpeshansky igorpeshansky igorpeshansky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Subbarker @igorpeshansky