packaging: add rsyslog as dependency to packages #1696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds rsyslog as package dependencies to both deb and rpm packages.
braydonk
changed the title
debian/control
Outdated
| Depends: ${shlibs:Depends}, ${misc:Depends} | ||
| Depends: ${shlibs:Depends}, | ||
| ${misc:Depends}, | ||
| rsyslog | system-log-daemon |
There was a problem hiding this comment.
Explicit dependencies generally appear first, don't they? @quentinmit could confirm.
There was a problem hiding this comment.
I think you're right. Fixed in 43aedd1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds rsyslog as package dependencies to both deb and rpm packages.
Related issue
b/339061751
How has this been tested?
Local docker build successful, but the real test is the integration tests in this PR.
Checklist: