Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(not working) Simplify UploadContent on linux and windows #1640

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

martijnvans
Copy link
Contributor

@martijnvans martijnvans commented Mar 11, 2024

Description

TODO: get windows codepath working and passing all test cases. The trouble is getting it to pass through the bytes without adding or removing any newlines.

TODO: remove mentions of TRANSFERS_BUCKET as it is not needed anymore

Related issue

How has this been tested?

Checklist:

  • Unit tests
    • Unit tests do not apply.
    • Unit tests have been added/modified and passed for this PR.
  • Integration tests
    • Integration tests do not apply.
    • Integration tests have been added/modified and passed for this PR.
  • Documentation
    • This PR introduces no user visible changes.
    • This PR introduces user visible changes and the corresponding documentation change has been made.
  • Minor version bump
    • This PR introduces no new features.
    • This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
    • This PR bumps the version.

@martijnvans martijnvans changed the title Simplify UploadContent on linux and Windows Simplify UploadContent on linux Mar 21, 2024
@martijnvans martijnvans changed the title Simplify UploadContent on linux (not working) Simplify UploadContent on linux and windows Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant