Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resource_tags argument definitions to resource_bigquery_table documentation #10712

Merged
merged 1 commit into from
May 17, 2024

Conversation

wj-chen
Copy link
Member

@wj-chen wj-chen commented May 15, 2024

Add resource_tags argument definitions to resource_bigquery_table documentation

Release Note Template for Downstream PRs (will be copied)

bigquery: add resource_tags argument definitions to resource_bigquery_table documentation

@github-actions github-actions bot requested a review from rileykarson May 15, 2024 19:35
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 11 insertions(+))
google-beta provider: Diff ( 1 file changed, 11 insertions(+))

expected to be the short name, for example "Production".

* `allow_resource_tags_on_deletion` - (Optional, [Beta](https://terraform.io/docs/providers/google/guides/provider_versions.html))
This field is in beta. Whether or not to allow table deletion when there are
Copy link
Contributor

@sachinpro sachinpro May 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit(optional): Maybe language like "Setting this to true will allow table deletion when there are still resource tags attached." is a tad clearer.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest this as well. I'm going to merge this now anyways, but it can be done in a followup if you'd like!

Copy link

This PR has been waiting for review for 2 days. Please take a look! Use the label disable-review-reminders to disable these notifications.

@rileykarson rileykarson merged commit 1c8b63f into GoogleCloudPlatform:main May 17, 2024
11 checks passed
avijain25 pushed a commit to avijain25/magic-modules that referenced this pull request May 21, 2024
ma-g-22 pushed a commit to ma-g-22/magic-modules that referenced this pull request May 21, 2024
pengq-google pushed a commit to pengq-google/magic-modules that referenced this pull request May 21, 2024
Cheriit pushed a commit to Cheriit/magic-modules that referenced this pull request Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants