Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add definition of table_replication_info to public documentation and bigquery/Table.yaml #10711

Merged
merged 1 commit into from
May 21, 2024

Conversation

wj-chen
Copy link
Member

@wj-chen wj-chen commented May 15, 2024

Add definition of table_replication_info to public documentation and bigquery/Table.yaml.

The argument was added to the resource in #9909.

Release Note Template for Downstream PRs (will be copied)

@github-actions github-actions bot requested a review from c2thorn May 15, 2024 19:19
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 16 insertions(+))
google-beta provider: Diff ( 1 file changed, 16 insertions(+))

Copy link

This PR has been waiting for review for 2 days. Please take a look! Use the label disable-review-reminders to disable these notifications.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 16 insertions(+))
google-beta provider: Diff ( 1 file changed, 16 insertions(+))

@wj-chen
Copy link
Member Author

wj-chen commented May 20, 2024

Hi @c2thorn, this is ready for review. Could you take a look? Thanks.

@c2thorn
Copy link
Member

c2thorn commented May 21, 2024

documentation-only changes don't need to have a release note, so I'm removing it. Going to go ahead and merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants