Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for 'alloydb.googleapis.com/Instance' to TGC #10710

Merged
merged 2 commits into from
May 17, 2024
Merged

Add support for 'alloydb.googleapis.com/Instance' to TGC #10710

merged 2 commits into from
May 17, 2024

Conversation

dvfons
Copy link
Contributor

@dvfons dvfons commented May 15, 2024

Release Note Template for Downstream PRs (will be copied)

@github-actions github-actions bot requested a review from NickElliot May 15, 2024 18:27
@github-actions GitHub Actions
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label May 15, 2024
@github-actions GitHub Actions
Copy link

This PR has been waiting for review for 2 days. Please take a look! Use the label disable-review-reminders to disable these notifications.

@dvfons
Copy link
Contributor Author

dvfons commented May 17, 2024

hey @NickElliot could you please make a reviwe this PR?

@modular-magician modular-magician removed the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label May 17, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

terraform-google-conversion: Diff ( 4 files changed, 78 insertions(+))

@NickElliot NickElliot merged commit 857c91f into GoogleCloudPlatform:main May 17, 2024
11 checks passed
@modular-magician modular-magician mentioned this pull request May 17, 2024
Merged
@dvfons dvfons deleted the alloyDbInstance branch May 20, 2024 11:16
avijain25 pushed a commit to avijain25/magic-modules that referenced this pull request May 21, 2024
@dvfons @avijain25
Add support for 'alloydb.googleapis.com/Instance' to TGC (GoogleClou…
cb9abdc 
…dPlatform#10710)
ma-g-22 pushed a commit to ma-g-22/magic-modules that referenced this pull request May 21, 2024
@dvfons @ma-g-22
Add support for 'alloydb.googleapis.com/Instance' to TGC (GoogleClou…
4767a7d 
…dPlatform#10710)
pengq-google pushed a commit to pengq-google/magic-modules that referenced this pull request May 21, 2024
@dvfons @pengq-google
Add support for 'alloydb.googleapis.com/Instance' to TGC (GoogleClou…
cb4ff6a 
…dPlatform#10710)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickElliot NickElliot NickElliot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@dvfons @modular-magician @NickElliot