-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Suport for google_dataflow_job
to TGC
#10705
Add Suport for google_dataflow_job
to TGC
#10705
Conversation
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
This PR has been waiting for review for 2 days. Please take a look! Use the label |
mmv1/third_party/tgc/tests/data/example_google_dataflow_job.json
Outdated
Show resolved
Hide resolved
mmv1/third_party/tgc/tests/data/example_google_dataflow_job.json
Outdated
Show resolved
Hide resolved
mmv1/third_party/tgc/tests/data/example_google_dataflow_job.json
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments above- given this is a handwritten resource we can align w/ CAI easily, and probably want to export a live resource and work off that for the testdata.
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
adding support for dataflow.googleapis.com/Job