Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

temp #10699

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

temp #10699

wants to merge 1 commit into from

Conversation

googlyrahman
Copy link
Member

Release Note Template for Downstream PRs (will be copied)


@github-actions github-actions bot requested a review from zli82016 May 14, 2024 20:27
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@zli82016, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 715 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 715 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 99 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_storage_anywhere_cache (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_storage_anywhere_cache" "primary" {
  admission_policy = # value needed
  bucket           = # value needed
  ttl              = # value needed
  zone             = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 93
Passed tests: 87
Skipped tests: 6
Affected tests: 0

Click here to see the affected service packages
  • storage

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log

Copy link

This PR has been waiting for review for 2 days. Please take a look! Use the label disable-review-reminders to disable these notifications.

Copy link
Member

@zli82016 zli82016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@googlyrahman , can you please fix the unit tests and lints? Thanks.

@googlyrahman
Copy link
Member Author

This is not meant for review.

@NickElliot
Copy link
Contributor

PR exists for discussing implementation while seeing diffs easily, commenting for accurate review records

@NickElliot NickElliot requested review from NickElliot and removed request for NickElliot May 23, 2024 17:47
Copy link
Contributor

@NickElliot NickElliot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pending discussions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants