-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
temp #10699
base: main
Are you sure you want to change the base?
temp #10699
Conversation
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @zli82016, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_storage_anywhere_cache" "primary" {
admission_policy = # value needed
bucket = # value needed
ttl = # value needed
zone = # value needed
}
|
Tests analyticsTotal tests: Click here to see the affected service packages
|
This PR has been waiting for review for 2 days. Please take a look! Use the label |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@googlyrahman , can you please fix the unit tests and lints? Thanks.
This is not meant for review. |
PR exists for discussing implementation while seeing diffs easily, commenting for accurate review records |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pending discussions
Release Note Template for Downstream PRs (will be copied)