Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for google_compute_instance_group to TGC #10695

Merged
merged 7 commits into from
May 23, 2024
Merged

Add support for google_compute_instance_group to TGC #10695

merged 7 commits into from
May 23, 2024

Conversation

delimaneto
Copy link
Contributor

adding support for compute.googleapis.com/InstanceGroup

@github-actions github-actions bot requested a review from roaks3 May 14, 2024 16:05
@github-actions GitHub Actions
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label May 14, 2024
@github-actions GitHub Actions
Copy link

This PR has been waiting for review for 2 days. Please take a look! Use the label disable-review-reminders to disable these notifications.

@github-actions GitHub Actions
Copy link

@GoogleCloudPlatform/terraform-team This PR has been waiting for review for 7 days. Please take a look! Use the label disable-review-reminders to disable these notifications.

@delimaneto delimaneto requested a review from sushant00 May 22, 2024 13:57
roaks3
roaks3 approved these changes May 22, 2024
View reviewed changes
Copy link
Contributor

@roaks3 roaks3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mmv1/third_party/tgc/compute_instance_group.go Outdated Show resolved Hide resolved
@github-actions github-actions bot requested a review from roaks3 May 22, 2024 17:57
@modular-magician modular-magician removed the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label May 23, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

terraform-google-conversion: Diff ( 5 files changed, 196 insertions(+))

@roaks3 roaks3 merged commit 67e3b1b into GoogleCloudPlatform:main May 23, 2024
12 checks passed
@modular-magician modular-magician mentioned this pull request May 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roaks3 roaks3 roaks3 approved these changes

@sushant00 sushant00 sushant00 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@delimaneto @modular-magician @roaks3 @sushant00