Prevent permadiff on monitoring_uptime_check_config

[VenelinMartinov]

Fixes a permadiff on uptime check config which causes it to be recreated every time.

The labels property in the monitored_resource property should ignore changes to the project_id label if not set by the user. GCP sets the project_id and that causes the resource to exhibit a diff and get recreated every time.

fixes hashicorp/terraform-provider-google#18038

Release Note Template for Downstream PRs (will be copied)

monitoring: fixed a permadiff with `monitored_resource.labels` property in the `google_monitoring_uptime_check_config` resource

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[c2thorn]

Hi @VenelinMartinov, thanks for contributing this fix. Would you mind adding a test to https://github.com/GoogleCloudPlatform/magic-modules/blob/main/mmv1/third_party/terraform/services/monitoring/resource_monitoring_uptime_check_config_test.go that shows the currently failing scenario? There are other examples there and we have documentation under the handwritten tab in https://googlecloudplatform.github.io/magic-modules/develop/test/test/#add-a-create-test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 15 insertions(+), 5 deletions(-))
google-beta provider: Diff ( 1 file changed, 15 insertions(+), 5 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+))

[modular-magician]

Tests analytics

Total tests: 55
Passed tests: 52
Skipped tests: 3
Affected tests: 0

Click here to see the affected service packages

• monitoring

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log

[VenelinMartinov]

Hi @c2thorn, thanks for your review. I've added a test as suggested. I verified that it fails before my fix and is fixed after.

I've also verified that hashicorp/terraform-provider-google#18038 no longer reproes with the fix.

LMK if there are any other issues here.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 76 insertions(+), 5 deletions(-))
google-beta provider: Diff ( 2 files changed, 76 insertions(+), 5 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+))

[modular-magician]

Tests analytics

Total tests: 56
Passed tests: 52
Skipped tests: 3
Affected tests: 1

Click here to see the affected service packages

• monitoring

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccMonitoringUptimeCheckConfig_noProjectId

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccMonitoringUptimeCheckConfig_noProjectId[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

[c2thorn]

LGTM thank you!