Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting both enable_autopilot and workload_identity_config in google_container_cluster resource #10691

Merged
merged 5 commits into from
May 16, 2024

Conversation

AshZhang
Copy link
Member

@AshZhang AshZhang commented May 13, 2024

This PR enables the creation of GKE clusters with both Autopilot and WorkloadALTS enabled (both enable_autopilot and workload_alts_config block set).

The workloadALTSConfig JSON field in the GKE cluster REST resource requires the workloadIdentityConfig field to be present as well, so the workload_alts_config block requires the workload_identity_config block to be present. This PR removes the ConflictsWith constraint between enable_autopilot and workload_identity_config so that a non-empty workload_identity_config block can be specified to satisfy the REST API to create the cluster.

Release Note Template for Downstream PRs (will be copied)

container: allowed both `enable_autopilot` and `workload_identity_config` to be set in `google_container_cluster` resource.

Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@shuyama1, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 46 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 2 files changed, 94 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 195
Passed tests: 183
Skipped tests: 10
Affected tests: 2

Click here to see the affected service packages
  • container

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccContainerCluster_withWorkloadALTSConfigAutopilot|TestAccContainerCluster_withWorkloadIdentityConfigAutopilot

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccContainerCluster_withWorkloadALTSConfigAutopilot[Debug log]
TestAccContainerCluster_withWorkloadIdentityConfigAutopilot[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 46 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 2 files changed, 97 insertions(+), 3 deletions(-))

1 similar comment
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 46 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 2 files changed, 97 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 195
Passed tests: 185
Skipped tests: 10
Affected tests: 0

Click here to see the affected service packages
  • container

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 195
Passed tests: 185
Skipped tests: 10
Affected tests: 0

Click here to see the affected service packages
  • container

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log

Copy link
Member

@shuyama1 shuyama1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only a small nitpick

@github-actions github-actions bot requested a review from shuyama1 May 15, 2024 17:49
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 46 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 2 files changed, 129 insertions(+), 35 deletions(-))

1 similar comment
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 46 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 2 files changed, 129 insertions(+), 35 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 195
Passed tests: 185
Skipped tests: 10
Affected tests: 0

Click here to see the affected service packages
  • container

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 195
Passed tests: 185
Skipped tests: 10
Affected tests: 0

Click here to see the affected service packages
  • container

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log

Copy link
Member

@shuyama1 shuyama1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants