Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove self_link from network security resources that don't expose it #10687

Closed
wants to merge 1 commit into from

Conversation

LucaPrete
Copy link
Member

@LucaPrete LucaPrete commented May 13, 2024

Removes self_link output parameters from network security resources that don't expose it through REST APIs.

This PR removes the self_link I added by mistake, even if it wasn't exported by REST APIs of the following resources:

  • google_network_security_security_profile
  • google_network_security_security_profile_group
  • google_network_security_endpoint
  • google_network_security_endpoint_association

Release Note Template for Downstream PRs (will be copied)

networksecurity: removed self_link output parameter from `google_network_security_security_profile`, `google_network_security_security_profile_group`, `google_network_security_endpoint`, `google_network_security_endpoint_association`

@github-actions github-actions bot requested a review from roaks3 May 13, 2024 19:59
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 8 files changed, 60 deletions(-))
google-beta provider: Diff ( 8 files changed, 60 deletions(-))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Field self_link within resource google_network_security_firewall_endpoint_association was either removed or renamed - reference
  • Field self_link within resource google_network_security_firewall_endpoint was either removed or renamed - reference
  • Field self_link within resource google_network_security_security_profile_group was either removed or renamed - reference
  • Field self_link within resource google_network_security_security_profile was either removed or renamed - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 37
Passed tests: 36
Skipped tests: 1
Affected tests: 0

Click here to see the affected service packages
  • networksecurity

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log

@c2thorn c2thorn requested review from c2thorn and removed request for roaks3 May 13, 2024 21:13
@LucaPrete LucaPrete closed this May 17, 2024
@LucaPrete LucaPrete deleted the removeSelfLink branch May 17, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants