Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove schema_config_mode_attr from secondary_ip_ranges #10686

Closed
wants to merge 1 commit into from

Conversation

trodge
Copy link
Contributor

@trodge trodge commented May 13, 2024

Release Note Template for Downstream PRs (will be copied)

compute: fixed an issue where `secondary_ip_range.reserved_internal_range` in `google_compute_subnetwork` was incorrectly behaving as required

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 3 insertions(+), 4 deletions(-))
google-beta provider: Diff ( 1 file changed, 3 insertions(+), 4 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 917
Passed tests: 844
Skipped tests: 72
Affected tests: 1

Click here to see the affected service packages
  • compute

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccComputeSubnetwork_secondaryIpRanges

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComputeSubnetwork_secondaryIpRanges[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

@trodge trodge closed this May 29, 2024
@trodge trodge deleted the compute-subnetwork branch May 29, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants