Add 'force' parameter to all Datastream resources

[alexandrunagy]

Adds the 'force' parameter for Datastream resources. This parameter allows creating the resources without validations.

The API parameter definition for each resource:

• ConnectionProfile: https://cloud.google.com/datastream/docs/reference/rest/v1/projects.locations.connectionProfiles/create#query-parameters
• PrivateConnection: https://cloud.google.com/datastream/docs/reference/rest/v1/projects.locations.privateConnections/create#query-parameters
• Stream: https://cloud.google.com/datastream/docs/reference/rest/v1/projects.locations.streams/create#query-parameters

Fixes hashicorp/terraform-provider-google#14022

Release Note Template for Downstream PRs (will be copied)

datastream: added `create_without_validation` field to `google_datastream_connection_profile`, `google_datastream_private_connection` and `google_datastream_stream` resources

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[slevenick]

Can you add this field to some tests so we can validate that it works correctly?

[alexandrunagy]

@slevenick added it to some, let me know if there are other places where I should add it

[github-actions]

This PR has been waiting for review for 2 days. Please take a look! Use the label disable-review-reminders to disable these notifications.

[slevenick]

I'm thinking we should rename this field. Usually force is used for a force-delete behavior, as described in https://google.aip.dev/165

Maybe force_create or create_without_validation would be more clear about what this actually does?

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 10 files changed, 46 insertions(+), 11 deletions(-))
google-beta provider: Diff ( 10 files changed, 46 insertions(+), 11 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_datastream_connection_profile (9 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_datastream_connection_profile" "primary" {
  force = # value needed
}

Resource: google_datastream_private_connection (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_datastream_private_connection" "primary" {
  force = # value needed
}

Resource: google_datastream_stream (5 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_datastream_stream" "primary" {
  force = # value needed
}

[modular-magician]

Tests analytics

Total tests: 11
Passed tests: 1
Skipped tests: 7
Affected tests: 3

Click here to see the affected service packages

• datastream

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDatastreamConnectionProfile_datastreamConnectionProfileBasicExample|TestAccDatastreamConnectionProfile_datastreamConnectionProfileFullExample|TestAccDatastreamPrivateConnection_datastreamPrivateConnectionFullExample

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDatastreamConnectionProfile_datastreamConnectionProfileBasicExample[Debug log]
TestAccDatastreamConnectionProfile_datastreamConnectionProfileFullExample[Debug log]
TestAccDatastreamPrivateConnection_datastreamPrivateConnectionFullExample[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

[alexandrunagy]

I'm thinking we should rename this field. Usually force is used for a force-delete behavior, as described in https://google.aip.dev/165

Maybe force_create or create_without_validation would be more clear about what this actually does?

@slevenick renamed to create_without_validation

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 10 files changed, 46 insertions(+), 11 deletions(-))
google-beta provider: Diff ( 10 files changed, 46 insertions(+), 11 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_datastream_connection_profile (9 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_datastream_connection_profile" "primary" {
  create_without_validation = # value needed
}

Resource: google_datastream_private_connection (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_datastream_private_connection" "primary" {
  create_without_validation = # value needed
}

Resource: google_datastream_stream (5 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_datastream_stream" "primary" {
  create_without_validation = # value needed
}

[modular-magician]

Tests analytics

Total tests: 11
Passed tests: 4
Skipped tests: 7
Affected tests: 0

Click here to see the affected service packages

• datastream

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log