Support behavioral changes to instance, instance template's max_run_duration feature on Beta #10683

arungantasala · 2024-05-13T17:52:34Z

Max run duration(MRD) feature support in terraform was added in #6812. There are behavioral changes in the feature which needs further changes.

max_run_duration is not a one time intent
Add STOP instance termination action with MRD
Support MRD on instances with attached local SSDs.

See SchedulingOnInstanceStopAction section in https://pkg.go.dev/google.golang.org/api/compute/v0.beta.

Fix for hashicorp/terraform-provider-google#13005

Closes hashicorp/terraform-provider-google#13671

Release Note Template for Downstream PRs (will be copied)

compute: added `on_instance_stop_action` field to `google_compute_instance`, `google_compute_instance_template`, and `google_compute_instance_from_machine_image ` resources (beta)

github-actions · 2024-05-13T17:53:12Z

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@SarahFrench, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

modular-magician · 2024-05-13T18:04:09Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 136 insertions(+), 24 deletions(-))
google-beta provider: Diff ( 6 files changed, 412 insertions(+), 41 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 39 insertions(+), 3 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_instance (267 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_instance" "primary" {
  scheduling {
    maintenance_interval = # value needed
  }
}

Resource: google_compute_instance_from_machine_image (5 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_instance_from_machine_image" "primary" {
  scheduling {
    instance_termination_action = # value needed
    maintenance_interval        = # value needed
    min_node_cpus               = # value needed
    on_host_maintenance         = # value needed
    on_instance_stop_action {
      discard_local_ssd = # value needed
    }
    preemptible        = # value needed
    provisioning_model = # value needed
  }
}

Resource: google_compute_instance_from_template (10 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_instance_from_template" "primary" {
  scheduling {
    instance_termination_action = # value needed
    maintenance_interval        = # value needed
    min_node_cpus               = # value needed
    on_host_maintenance         = # value needed
    on_instance_stop_action {
      discard_local_ssd = # value needed
    }
    preemptible        = # value needed
    provisioning_model = # value needed
  }
}

modular-magician · 2024-05-13T18:25:55Z

Tests analytics

Total tests: 923
Passed tests: 844
Skipped tests: 72
Affected tests: 7

Click here to see the affected service packages

Action taken

Found 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2024-05-13T18:32:04Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComputeInstanceTemplate_spot_maxRunDuration_deleteTerminationAction[Debug log]
TestAccComputeInstanceTemplate_spot_maxRunDuration_stopTerminationAction[Debug log]
TestAccComputeInstance_localSsdVM_maxRunDuration_stopTerminationAction[Debug log]
TestAccComputeInstance_maxRunDuration_update[Debug log]
TestAccComputeInstance_spotVM_maxRunDuration_deleteTerminationAction[Debug log]
TestAccComputeInstance_standardVM_maxRunDuration_deleteTerminationAction[Debug log]
TestAccComputeInstance_standardVM_maxRunDuration_stopTerminationAction[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

SarahFrench

Thanks for your PR - the new tests look good and are passing but I want to make sure this message about missing test coverage is acknowledged.

That message shows that the new on_instance_stop_action field is also being added to the google_compute_instance_from_machine_image resource. This is because schemas are re-used in the provider (see here for google_compute_instance_from_machine_image).

Firstly, could you please update the documentation for google_compute_instance_from_machine_image to include the new field?

And then, could you please add a basic acceptance test that tests the new field/behaviour you've added to google_compute_instance_from_machine_image?

I'm happy for us to ignore the message's warnings about lack of test coverage on fields that your PR isn't adding.

…late, instance_template

modular-magician · 2024-05-16T01:55:43Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 234 insertions(+), 25 deletions(-))
google-beta provider: Diff ( 10 files changed, 721 insertions(+), 42 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 54 insertions(+), 4 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_instance (271 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_instance" "primary" {
  scheduling {
    maintenance_interval = # value needed
  }
}

Resource: google_compute_instance_from_machine_image (6 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_instance_from_machine_image" "primary" {
  scheduling {
    maintenance_interval = # value needed
    min_node_cpus        = # value needed
    on_host_maintenance  = # value needed
    preemptible          = # value needed
  }
}

Resource: google_compute_instance_from_template (10 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_instance_from_template" "primary" {
  scheduling {
    instance_termination_action = # value needed
    maintenance_interval        = # value needed
    min_node_cpus               = # value needed
    on_host_maintenance         = # value needed
    on_instance_stop_action {
      discard_local_ssd = # value needed
    }
    preemptible        = # value needed
    provisioning_model = # value needed
  }
}

modular-magician · 2024-05-16T01:59:48Z

Tests analytics

Total tests: 46
Passed tests: 9
Skipped tests: 37
Affected tests: 0

Click here to see the affected service packages

Non-exercised tests

Tests were added that are skipped in VCR:

TestAccComputeInstanceFromMachineImage_maxRunDuration
TestAccComputeInstanceTemplate_maxRunDuration_onInstanceStopAction
TestAccComputeInstanceTemplate_spot_maxRunDuration_deleteTerminationAction
TestAccComputeInstanceTemplate_spot_maxRunDuration_stopTerminationAction
TestAccComputeInstance_localSsdVM_maxRunDuration_stopTerminationAction
TestAccComputeInstance_maxRunDuration_update
TestAccComputeInstance_spotVM_maxRunDuration_deleteTerminationAction
TestAccComputeInstance_standardVM_maxRunDuration_deleteTerminationAction
TestAccComputeInstance_standardVM_maxRunDuration_stopTerminationAction
TestAccComputeRegionInstanceTemplate_maxRunDuration_onInstanceStopAction

$\textcolor{red}{\textsf{Errors occurred during REPLAYING mode. Please fix them to complete your PR.}}$
View the build log

modular-magician · 2024-05-16T03:29:45Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 234 insertions(+), 25 deletions(-))
google-beta provider: Diff ( 11 files changed, 853 insertions(+), 43 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 54 insertions(+), 4 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_instance (271 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_instance" "primary" {
  scheduling {
    maintenance_interval = # value needed
  }
}

Resource: google_compute_instance_from_machine_image (6 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_instance_from_machine_image" "primary" {
  scheduling {
    maintenance_interval = # value needed
    min_node_cpus        = # value needed
    on_host_maintenance  = # value needed
    preemptible          = # value needed
  }
}

Resource: google_compute_instance_from_template (11 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_instance_from_template" "primary" {
  scheduling {
    maintenance_interval = # value needed
    min_node_cpus        = # value needed
    on_host_maintenance  = # value needed
    preemptible          = # value needed
  }
}

modular-magician · 2024-05-16T03:34:03Z

Tests analytics

Total tests: 46
Passed tests: 9
Skipped tests: 37
Affected tests: 0

Click here to see the affected service packages

Non-exercised tests

Tests were added that are skipped in VCR:

TestAccComputeInstanceFromMachineImage_maxRunDuration
TestAccComputeInstanceFromTemplate_maxRunDuration_onInstanceStopAction
TestAccComputeInstanceTemplate_maxRunDuration_onInstanceStopAction
TestAccComputeInstanceTemplate_spot_maxRunDuration_deleteTerminationAction
TestAccComputeInstanceTemplate_spot_maxRunDuration_stopTerminationAction
TestAccComputeInstance_localSsdVM_maxRunDuration_stopTerminationAction
TestAccComputeInstance_maxRunDuration_update
TestAccComputeInstance_spotVM_maxRunDuration_deleteTerminationAction
TestAccComputeInstance_standardVM_maxRunDuration_deleteTerminationAction
TestAccComputeInstance_standardVM_maxRunDuration_stopTerminationAction
TestAccComputeRegionInstanceTemplate_maxRunDuration_onInstanceStopAction

$\textcolor{red}{\textsf{Errors occurred during REPLAYING mode. Please fix them to complete your PR.}}$
View the build log

arungantasala · 2024-05-16T03:37:16Z

/gcbrun

arungantasala · 2024-05-16T03:45:41Z

google_compute_instance_from_machine_image resource's documentation mentions "In addition to these, most* arguments from google_compute_instance are supported as a way to override the properties in the machine image." This includes the new argument on_instance_stop_action
Added acceptance tests for the new field at all the relavant places

SarahFrench

The problem reported here is a panic that occurs when running the TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy/access_config_update_access_config acceptance test:

panic: interface conversion: interface {} is []interface {}, not map[string]interface {}

goroutine 68179 [running]:
github.com/hashicorp/terraform-provider-google-beta/google-beta/services/compute.hasMaxRunDurationChanged(...)
	/go/src/github.com/modular-magician/terraform-provider-google-beta/google-beta/services/compute/compute_instance_helpers.go:705
github.com/hashicorp/terraform-provider-google-beta/google-beta/services/compute.schedulingHasChangeRequiringReboot(0xc001302ca8?)
	/go/src/github.com/modular-magician/terraform-provider-google-beta/google-beta/services/compute/compute_instance_helpers.go:658 +0x3ce
github.com/hashicorp/terraform-provider-google-beta/google-beta/services/compute.resourceComputeInstanceUpdate(0xc001f3f680, {0x4613dc0?, 0xc000161000?})
	/go/src/github.com/modular-magician/terraform-provider-google-beta/google-beta/services/compute/resource_compute_instance.go:1890 +0x1437

The line compute_instance_helpers.go:705 in the generated provider is the beginning of hasMaxRunDurationChanged function where empty interfaces are converted to maps

SarahFrench

Please address the panic described in #10683 (review)

modular-magician · 2024-05-16T17:46:13Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 234 insertions(+), 25 deletions(-))
google-beta provider: Diff ( 11 files changed, 853 insertions(+), 43 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 54 insertions(+), 4 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_instance (271 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_instance" "primary" {
  scheduling {
    maintenance_interval = # value needed
  }
}

Resource: google_compute_instance_from_machine_image (6 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_instance_from_machine_image" "primary" {
  scheduling {
    maintenance_interval = # value needed
    min_node_cpus        = # value needed
    on_host_maintenance  = # value needed
    preemptible          = # value needed
  }
}

Resource: google_compute_instance_from_template (11 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_instance_from_template" "primary" {
  scheduling {
    maintenance_interval = # value needed
    min_node_cpus        = # value needed
    on_host_maintenance  = # value needed
    preemptible          = # value needed
  }
}

modular-magician · 2024-05-16T17:50:29Z

Tests analytics

Total tests: 46
Passed tests: 9
Skipped tests: 37
Affected tests: 0

Click here to see the affected service packages

Non-exercised tests

Tests were added that are skipped in VCR:

TestAccComputeInstanceFromMachineImage_maxRunDuration
TestAccComputeInstanceFromTemplate_maxRunDuration_onInstanceStopAction
TestAccComputeInstanceTemplate_maxRunDuration_onInstanceStopAction
TestAccComputeInstanceTemplate_spot_maxRunDuration_deleteTerminationAction
TestAccComputeInstanceTemplate_spot_maxRunDuration_stopTerminationAction
TestAccComputeInstance_localSsdVM_maxRunDuration_stopTerminationAction
TestAccComputeInstance_maxRunDuration_update
TestAccComputeInstance_spotVM_maxRunDuration_deleteTerminationAction
TestAccComputeInstance_standardVM_maxRunDuration_deleteTerminationAction
TestAccComputeInstance_standardVM_maxRunDuration_stopTerminationAction
TestAccComputeRegionInstanceTemplate_maxRunDuration_onInstanceStopAction

$\textcolor{red}{\textsf{Errors occurred during REPLAYING mode. Please fix them to complete your PR.}}$
View the build log

arungantasala · 2024-05-16T17:53:17Z

Thanks Sarah for pointing this out. I was not able to reproduce the issue locally by running the test you pointed out. It is somehow failing on its own due to an unrelated issue. But, i have pushed a change to fix this. I will take another look if the panic shows up again.

modular-magician · 2024-05-16T17:58:03Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 234 insertions(+), 25 deletions(-))
google-beta provider: Diff ( 11 files changed, 853 insertions(+), 43 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 54 insertions(+), 4 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_instance (271 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_instance" "primary" {
  scheduling {
    maintenance_interval = # value needed
  }
}

Resource: google_compute_instance_from_machine_image (6 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_instance_from_machine_image" "primary" {
  scheduling {
    maintenance_interval = # value needed
    min_node_cpus        = # value needed
    on_host_maintenance  = # value needed
    preemptible          = # value needed
  }
}

Resource: google_compute_instance_from_template (11 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_instance_from_template" "primary" {
  scheduling {
    maintenance_interval = # value needed
    min_node_cpus        = # value needed
    on_host_maintenance  = # value needed
    preemptible          = # value needed
  }
}

modular-magician · 2024-05-16T18:01:57Z

Tests analytics

Total tests: 46
Passed tests: 9
Skipped tests: 37
Affected tests: 0

Click here to see the affected service packages

Non-exercised tests

Tests were added that are skipped in VCR:

TestAccComputeInstanceFromMachineImage_maxRunDuration
TestAccComputeInstanceFromTemplate_maxRunDuration_onInstanceStopAction
TestAccComputeInstanceTemplate_maxRunDuration_onInstanceStopAction
TestAccComputeInstanceTemplate_spot_maxRunDuration_deleteTerminationAction
TestAccComputeInstanceTemplate_spot_maxRunDuration_stopTerminationAction
TestAccComputeInstance_localSsdVM_maxRunDuration_stopTerminationAction
TestAccComputeInstance_maxRunDuration_update
TestAccComputeInstance_spotVM_maxRunDuration_deleteTerminationAction
TestAccComputeInstance_standardVM_maxRunDuration_deleteTerminationAction
TestAccComputeInstance_standardVM_maxRunDuration_stopTerminationAction
TestAccComputeRegionInstanceTemplate_maxRunDuration_onInstanceStopAction

$\textcolor{red}{\textsf{Errors occurred during REPLAYING mode. Please fix them to complete your PR.}}$
View the build log

github-actions · 2024-05-18T09:39:41Z

This PR has been waiting for review for 2 days. Please take a look! Use the label disable-review-reminders to disable these notifications.

modular-magician · 2024-05-20T07:28:33Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 244 insertions(+), 25 deletions(-))
google-beta provider: Diff ( 11 files changed, 863 insertions(+), 43 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 64 insertions(+), 4 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_instance (271 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_instance" "primary" {
  scheduling {
    maintenance_interval = # value needed
  }
}

Resource: google_compute_instance_from_machine_image (6 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_instance_from_machine_image" "primary" {
  scheduling {
    maintenance_interval = # value needed
    min_node_cpus        = # value needed
    on_host_maintenance  = # value needed
    preemptible          = # value needed
  }
}

Resource: google_compute_instance_from_template (11 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_instance_from_template" "primary" {
  scheduling {
    maintenance_interval = # value needed
    min_node_cpus        = # value needed
    on_host_maintenance  = # value needed
    preemptible          = # value needed
  }
}

modular-magician · 2024-05-20T07:49:46Z

Tests analytics

Total tests: 932
Passed tests: 860
Skipped tests: 72
Affected tests: 0

Click here to see the affected service packages

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log

SarahFrench

Looks good - the panic is addressed and there is test coverage for all the new fields added by this PR.

Spotted a code change in GA when this PR is meant to be beta-only changes

SarahFrench

I approved but then from looking at your release note I remembered that this PR is meant to be causing changes in the beta provider only. I looked at the diffs that this PR will create in the GA provider and noticed that there are non-trivial changes being introduced by this PR in the GA provider. We want to get to a state where this PR only causes changes to documentation in the GA provider.

I've added a few suggestions in my review, but could you please also ensure that the changes to the _test.go files are also made only in the Beta provider? To achieve this you will need to convert any affected .go files into .go.erb files, as that'll allow the code to be templated in a conditional way based on the provider that's being generated.

When converting a .go file to a .go.erb file you just need to add the new extension to the filename and then add <% autogen_exception -%> as the first line of the file (example here).

mmv1/third_party/terraform/services/compute/compute_instance_helpers.go.erb

SarahFrench · 2024-05-20T10:16:52Z

mmv1/third_party/terraform/services/compute/compute_instance_helpers.go.erb

@@ -656,7 +692,7 @@ func schedulingHasChangeRequiringReboot(d *schema.ResourceData) bool {
 	oScheduling := o.([]interface{})[0].(map[string]interface{})
 	newScheduling := n.([]interface{})[0].(map[string]interface{})

-	return hasNodeAffinitiesChanged(oScheduling, newScheduling)
+	return hasNodeAffinitiesChanged(oScheduling, newScheduling) || hasMaxRunDurationChanged(oScheduling, newScheduling)


This suggested change should mean that the changes only appear in the Beta provider

Suggested change

return hasNodeAffinitiesChanged(oScheduling, newScheduling) || hasMaxRunDurationChanged(oScheduling, newScheduling)

<% unless version == 'ga' -%>

return hasNodeAffinitiesChanged(oScheduling, newScheduling) || hasMaxRunDurationChanged(oScheduling, newScheduling)

<% else -%>

return hasNodeAffinitiesChanged(oScheduling, newScheduling)

<% end -%>

mmv1/third_party/terraform/services/compute/resource_compute_instance.go.erb

…compute_instance_helpers.go.erb Co-authored-by: Sarah French <15078782+SarahFrench@users.noreply.github.com>

…e/resource_compute_instance.go.erb Co-authored-by: Sarah French <15078782+SarahFrench@users.noreply.github.com>

modular-magician · 2024-05-20T15:46:39Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 219 insertions(+), 24 deletions(-))
google-beta provider: Diff ( 11 files changed, 862 insertions(+), 43 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 63 insertions(+), 4 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_instance (271 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_instance" "primary" {
  scheduling {
    maintenance_interval = # value needed
  }
}

Resource: google_compute_instance_from_machine_image (6 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_instance_from_machine_image" "primary" {
  scheduling {
    maintenance_interval = # value needed
    min_node_cpus        = # value needed
    on_host_maintenance  = # value needed
    preemptible          = # value needed
  }
}

Resource: google_compute_instance_from_template (11 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_instance_from_template" "primary" {
  scheduling {
    maintenance_interval = # value needed
    min_node_cpus        = # value needed
    on_host_maintenance  = # value needed
    preemptible          = # value needed
  }
}

Errors

google provider:

The diff processor failed to build. This is usually due to the downstream provider failing to compile.

modular-magician · 2024-05-20T15:48:58Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 219 insertions(+), 24 deletions(-))
google-beta provider: Diff ( 11 files changed, 862 insertions(+), 43 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 63 insertions(+), 4 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_instance (271 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_instance" "primary" {
  scheduling {
    maintenance_interval = # value needed
  }
}

Resource: google_compute_instance_from_machine_image (6 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_instance_from_machine_image" "primary" {
  scheduling {
    maintenance_interval = # value needed
    min_node_cpus        = # value needed
    on_host_maintenance  = # value needed
    preemptible          = # value needed
  }
}

Resource: google_compute_instance_from_template (11 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_instance_from_template" "primary" {
  scheduling {
    maintenance_interval = # value needed
    min_node_cpus        = # value needed
    on_host_maintenance  = # value needed
    preemptible          = # value needed
  }
}

Errors

google provider:

The diff processor failed to build. This is usually due to the downstream provider failing to compile.

modular-magician · 2024-05-20T15:57:50Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 41 insertions(+), 25 deletions(-))
google-beta provider: Diff ( 11 files changed, 862 insertions(+), 43 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 63 insertions(+), 4 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_instance (271 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_instance" "primary" {
  scheduling {
    maintenance_interval = # value needed
  }
}

Resource: google_compute_instance_from_machine_image (6 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_instance_from_machine_image" "primary" {
  scheduling {
    maintenance_interval = # value needed
    min_node_cpus        = # value needed
    on_host_maintenance  = # value needed
    preemptible          = # value needed
  }
}

Resource: google_compute_instance_from_template (11 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_instance_from_template" "primary" {
  scheduling {
    maintenance_interval = # value needed
    min_node_cpus        = # value needed
    on_host_maintenance  = # value needed
    preemptible          = # value needed
  }
}

Errors

google provider:

The diff processor failed to build. This is usually due to the downstream provider failing to compile.

modular-magician · 2024-05-20T16:07:30Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 40 insertions(+), 24 deletions(-))
google-beta provider: Diff ( 11 files changed, 863 insertions(+), 43 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 64 insertions(+), 4 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_instance (271 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_instance" "primary" {
  scheduling {
    maintenance_interval = # value needed
  }
}

Resource: google_compute_instance_from_machine_image (6 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_instance_from_machine_image" "primary" {
  scheduling {
    maintenance_interval = # value needed
    min_node_cpus        = # value needed
    on_host_maintenance  = # value needed
    preemptible          = # value needed
  }
}

Resource: google_compute_instance_from_template (11 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_instance_from_template" "primary" {
  scheduling {
    maintenance_interval = # value needed
    min_node_cpus        = # value needed
    on_host_maintenance  = # value needed
    preemptible          = # value needed
  }
}

modular-magician · 2024-05-20T16:07:49Z

Tests analytics

Total tests: 932
Passed tests: 860
Skipped tests: 72
Affected tests: 0

Click here to see the affected service packages

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log

modular-magician · 2024-05-20T16:12:22Z

Tests analytics

Total tests: 932
Passed tests: 860
Skipped tests: 72
Affected tests: 0

Click here to see the affected service packages

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log

modular-magician · 2024-05-20T16:19:02Z

Tests analytics

Total tests: 932
Passed tests: 860
Skipped tests: 72
Affected tests: 0

Click here to see the affected service packages

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log

modular-magician · 2024-05-20T16:28:55Z

Tests analytics

Total tests: 932
Passed tests: 860
Skipped tests: 72
Affected tests: 0

Click here to see the affected service packages

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log

arungantasala · 2024-05-20T16:53:37Z

Thanks Sarah for catching this. I have made changes as you suggested.

SarahFrench

Thanks for addressing the GA/Beta issue! I can see that the diffs for the GA provider still show changes in functions like testAccComputeInstanceTemplate_spot_maxRunDuration, however those functions are unused in the GA code base so the code change isn't user-facing. Because Go tolerates unused functions and those functions were already present in the GA code before this PR, I'm happy to merge this PR

…uration feature on Beta (GoogleCloudPlatform#10683) Co-authored-by: Sarah French <15078782+SarahFrench@users.noreply.github.com>

Support MRD with STOP, local SSD

3459681

github-actions bot requested a review from SarahFrench May 13, 2024 17:53

modular-magician added the service/compute-instances label May 13, 2024

SarahFrench requested changes May 15, 2024

View reviewed changes

Add acceptance tests for instance_machine_image, region_instance_temp…

d2ca3ef

…late, instance_template

arungantasala force-pushed the mrd branch from df13d3e to d2ca3ef Compare May 16, 2024 01:44

github-actions bot requested a review from SarahFrench May 16, 2024 01:45

Add acceptance tests for resource_compute_instance_from_template

6c579cc

SarahFrench reviewed May 16, 2024

View reviewed changes

Merge branch 'GoogleCloudPlatform:main' into mrd

aeb660d

github-actions bot requested a review from SarahFrench May 16, 2024 17:35

Fix the hasMaxRunDurationChanged method

670455d

SarahFrench requested changes May 16, 2024

View reviewed changes

github-actions bot requested a review from SarahFrench May 16, 2024 17:46

Attempt 2: Fix for the panic error

54a20ef

Merge branch 'GoogleCloudPlatform:main' into mrd

7381dff

SarahFrench previously approved these changes May 20, 2024

View reviewed changes

SarahFrench requested changes May 20, 2024

View reviewed changes

Update non GA changes in mmv1/third_party/terraform/services/compute/…

6365747

…compute_instance_helpers.go.erb Co-authored-by: Sarah French <15078782+SarahFrench@users.noreply.github.com>

github-actions bot requested a review from SarahFrench May 20, 2024 15:36

arungantasala and others added 2 commits May 20, 2024 08:36

Update non beta changes in mmv1/third_party/terraform/services/comput…

067e8e0

…e/resource_compute_instance.go.erb Co-authored-by: Sarah French <15078782+SarahFrench@users.noreply.github.com>

Update tests to only add in beta provider

8a09033

Fix GA provider

f2d2782

SarahFrench approved these changes May 20, 2024

View reviewed changes

SarahFrench merged commit 63bda5e into GoogleCloudPlatform:main May 20, 2024
12 checks passed

arungantasala mentioned this pull request May 20, 2024

Support VM max_run_duration with instance_termination_action=STOP hashicorp/terraform-provider-google#18112

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support behavioral changes to instance, instance template's max_run_duration feature on Beta #10683

Support behavioral changes to instance, instance template's max_run_duration feature on Beta #10683

arungantasala commented May 13, 2024 •

edited by SarahFrench

github-actions bot commented May 13, 2024

modular-magician commented May 13, 2024

modular-magician commented May 13, 2024

modular-magician commented May 13, 2024

SarahFrench left a comment

modular-magician commented May 16, 2024

modular-magician commented May 16, 2024

modular-magician commented May 16, 2024

modular-magician commented May 16, 2024

arungantasala commented May 16, 2024

arungantasala commented May 16, 2024 •

edited

SarahFrench left a comment

SarahFrench left a comment

modular-magician commented May 16, 2024

modular-magician commented May 16, 2024

arungantasala commented May 16, 2024

modular-magician commented May 16, 2024

modular-magician commented May 16, 2024

github-actions bot commented May 18, 2024

modular-magician commented May 20, 2024

modular-magician commented May 20, 2024

SarahFrench left a comment

SarahFrench left a comment

SarahFrench May 20, 2024

modular-magician commented May 20, 2024

modular-magician commented May 20, 2024

modular-magician commented May 20, 2024

modular-magician commented May 20, 2024

modular-magician commented May 20, 2024

modular-magician commented May 20, 2024

modular-magician commented May 20, 2024

modular-magician commented May 20, 2024

arungantasala commented May 20, 2024

SarahFrench left a comment

Support behavioral changes to instance, instance template's max_run_duration feature on Beta #10683

Support behavioral changes to instance, instance template's max_run_duration feature on Beta #10683

Conversation

arungantasala commented May 13, 2024 • edited by SarahFrench

github-actions bot commented May 13, 2024

modular-magician commented May 13, 2024

Diff report

Missing test report

modular-magician commented May 13, 2024

Tests analytics

Action taken

modular-magician commented May 13, 2024

SarahFrench left a comment

Choose a reason for hiding this comment

modular-magician commented May 16, 2024

Diff report

Missing test report

modular-magician commented May 16, 2024

Tests analytics

Non-exercised tests

modular-magician commented May 16, 2024

Diff report

Missing test report

modular-magician commented May 16, 2024

Tests analytics

Non-exercised tests

arungantasala commented May 16, 2024

arungantasala commented May 16, 2024 • edited

SarahFrench left a comment

Choose a reason for hiding this comment

SarahFrench left a comment

Choose a reason for hiding this comment

modular-magician commented May 16, 2024

Diff report

Missing test report

modular-magician commented May 16, 2024

Tests analytics

Non-exercised tests

arungantasala commented May 16, 2024

modular-magician commented May 16, 2024

Diff report

Missing test report

modular-magician commented May 16, 2024

Tests analytics

Non-exercised tests

github-actions bot commented May 18, 2024

modular-magician commented May 20, 2024

Diff report

Missing test report

modular-magician commented May 20, 2024

Tests analytics

SarahFrench left a comment

Choose a reason for hiding this comment

SarahFrench left a comment

Choose a reason for hiding this comment

SarahFrench May 20, 2024

Choose a reason for hiding this comment

modular-magician commented May 20, 2024

Diff report

Missing test report

Errors

modular-magician commented May 20, 2024

Diff report

Missing test report

Errors

modular-magician commented May 20, 2024

Diff report

Missing test report

Errors

modular-magician commented May 20, 2024

Diff report

Missing test report

modular-magician commented May 20, 2024

Tests analytics

modular-magician commented May 20, 2024

Tests analytics

modular-magician commented May 20, 2024

Tests analytics

modular-magician commented May 20, 2024

Tests analytics

arungantasala commented May 13, 2024 •

edited by SarahFrench

arungantasala commented May 16, 2024 •

edited