-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Customer Search Demo App #546
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
@CodeChamp-SS Can you add a description of your sample app to the PR Description? Also, all of the Images/PDF/CSV files make this PR quite large. These files should really be added to a Google Cloud Storage Bucket and linked in if needed, to reduce the size of the repository. We have a public Google Cloud Storage Bucket |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment. I will do a more thorough review once the files are cleaned up
@holtskinner you may put the following files/folders in the GCS bucket: |
@CodeChamp-SS I moved the requested files to GCS:
New Paths:
You can also access these through the public links https://storage.googleapis.com/github-repo/generative-ai/sample-apps/customer-search/FD_TnC.pdf I also recommend moving the remaining images for the README and app to GCS and linking them in this way. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm stopping part way through to allow time to make some of the changes.
Overall there's a lot of duplicated code and most of this application seems to be overly complex. I would highly recommend refactoring and finding ways to reduce duplication and complexity. It will make the application code much more readable/understandable/maintainable.
@@ -0,0 +1,56 @@ | |||
# Cymbal Bank Website Demo: CymBuddy and Search | |||
|
|||
This repository contains the code for the Cymbal Bank demo website, a cutting-edge fintech platform designed to cater to the diverse needs of our customers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could this be more specific about what the app does/uses?
|
||
- The demo showcases the core functionalities and capabilities of the Cymbal Bank platform. | ||
- The investment data and recommendations are simulated and for illustrative purposes only. | ||
- This repository is intended for demonstration purposes and may not reflect the full features and functionalities of the final product. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What final product?
model = TextGenerationModel.from_pretrained("text-bison") | ||
|
||
response = model.predict( | ||
"""Generate a confirmation message on creating a fd. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is an "fd". Also, do you really need to use an llm to create a confirmation message/email? Seems like it should be a template
gemini/sample-apps/customer-search/functions/credit-card-imagen/main.py
Outdated
Show resolved
Hide resolved
gemini/sample-apps/customer-search/functions/event-recommendationv2/main.py
Outdated
Show resolved
Hide resolved
Thanks! Will replace the images/files in the code with these. |
Please re-assign to me and re-request review when ready. |
@check-spelling-bot Report🔴 Please reviewSee the 📂 files view, the 📜action log, or 📝 job summary for details. Unrecognized words (1304)
Some files were automatically ignored 🙈These sample patterns would exclude them:
You should consider adding them to:
File matching is via Perl regular expressions. To check these files, more of their words need to be in the dictionary than not. You can use To accept these unrecognized words as correct and update file exclusions, you could run the following commands... in a clone of the git@github.com:CodeChamp-SS/generative-ai.git repository curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/main/apply.pl' |
perl - 'https://github.com/GoogleCloudPlatform/generative-ai/actions/runs/9097637103/attempts/1' Available 📚 dictionaries could cover words not in the 📘 dictionary
Consider adding them (in with:
extra_dictionaries:
cspell:aws/aws.txt
cspell:fullstack/dict/fullstack.txt
cspell:python/src/python/python-lib.txt
cspell:html/dict/html.txt
cspell:python/src/python/python.txt To stop checking additional dictionaries, add (in check_extra_dictionaries: '' Pattern suggestions ✂️ (42)You could add these patterns to
Errors (4)See the 📂 files view, the 📜action log, or 📝 job summary for details.
See ❌ Event descriptions for more information. |
…ive-ai into pr/CodeChamp-SS/546
Hi @holtskinner, we have tried to resolve the suggestions you made, the other lint errors. I have created a new pull request #700 , please review it again. Thanks! |
Ok, you didn't need to make a new Pull Request for the changes, but it's okay. Please close out this Pull Request if it's no longer needed. |
this branch got a bit messy, so I thought creating a new one would be better. |
Description
Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
CONTRIBUTING
Guide.CODEOWNERS
for the file(s).nox -s format
from the repository root to format).Fixes #<issue_number_goes_here> 🦕