adds e2e test for anywhere cache #1900
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tulsishah
reviewed
May 10, 2024
| @@ -239,6 +239,25 @@ function run_e2e_tests_for_hns_bucket(){ | |||
| return 0 | |||
| } | |||
|
|
|||
| function run_e2e_tests_for_anywhere_cache(){ | |||
| local test_bucket_name="golang-grpc-test-lankita-anywhere-cache-test" ## TODO: adding temporary bucket name for testing purpose | |||
There was a problem hiding this comment.
Can we set test bucket name with golang-grpc-test-gcsfuse-anywhere-cache-e2e-tests ?
There was a problem hiding this comment.
yes, in this PR just trying to run the test and see if cache is being used or not, will update final bucket name once cache usage is confirmed.
| local test_bucket_name="golang-grpc-test-lankita-anywhere-cache-test" ## TODO: adding temporary bucket name for testing purpose | ||
|
|
||
| echo "Running tests for Anywhere Cache" | ||
| run_non_parallel_tests TEST_DIR_HNS_GROUP "$test_bucket_name" ## TODO: separate group will be created for anywhere cache in final tests |
There was a problem hiding this comment.
nit: Should we add TODO above the code line?
There was a problem hiding this comment.
This will be deleted in final PR
| non_parallel_tests_pid_anywhere_cache_group_exit_code=$? | ||
|
|
||
| # clean_up test_bucket_name | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
run a set of existing integration for anywhere cache compatibility
Link to the issue in case of a bug fix.
337732802
Testing details