pass environment variables to go build command of build_gcsfuse to support builds behind an HTTP proxy #1899
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The problem I faced is described in the title, I hope this fix can be useful to someone else too.
I have a custom Dockerfile based on the original Dockerfile in this repo, and my build runs behind an HTTP proxy, the build was failing. I realized it was due the following code snippet in tools/build_gcsfuse/main.go:
This code ignores all the current environment variables, which is IMHO unexpected as it runs inside Docker which already takes care about creating an isolated environment with fresh values of environment variables.
The particular variable important for my case was
https_proxy
, without itgo build
was failing as it was unable to access internet directly.That variable was passed with
~/.docker/config.json
like described in Docker docs.Link to the issue in case of a bug fix.
NA
Testing details