Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement method to return bucket type from server #1898

Merged
merged 50 commits into from
May 27, 2024
Merged

Implement method to return bucket type from server #1898

merged 50 commits into from
May 27, 2024

Conversation

Tulsishah
Copy link
Collaborator

@Tulsishah Tulsishah commented May 9, 2024 •
edited

Description

Implemented FetchAndSetBucketType() method to get bucket type from GetStorageLayout(e.g. Hierarchical or NonHierarchical) and set it in bucketType.

Link to the issue in case of a bug fix.

NA

Testing details

  1. Manual - NA
  2. Unit tests - Added(Create mock control client)
  3. Integration tests - Added

@Tulsishah Tulsishah force-pushed the implement_method_to_return_bucket_type branch 2 times, most recently from 784ee51 to ba3c81c Compare May 10, 2024 09:22
@Tulsishah Tulsishah force-pushed the implement_method_to_return_bucket_type branch from 7c1f491 to 56c2096 Compare May 20, 2024 06:33
@Tulsishah Tulsishah changed the base branch from setting_bucket_type to master May 20, 2024 06:34
@Tulsishah Tulsishah added the execute-integration-tests Run only integration tests label May 20, 2024
@codecov Codecov
Copy link

codecov bot commented May 20, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.38%. Comparing base (d824d73) to head (986ec08).
Report is 2 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1898      +/-   ##
==========================================
+ Coverage   61.22%   61.38%   +0.16%     
==========================================
  Files         130      131       +1     
  Lines       12350    12379      +29     
==========================================
+ Hits         7561     7599      +38     
+ Misses       4448     4440       -8     
+ Partials      341      340       -1
Flag Coverage Δ
unittests 61.38% <100.00%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tulsishah Tulsishah marked this pull request as ready for review May 20, 2024 07:24
@Tulsishah Tulsishah requested a review from a team as a code owner May 20, 2024 07:24
raj-prince
raj-prince previously approved these changes May 21, 2024
View reviewed changes
raj-prince
raj-prince reviewed May 21, 2024
View reviewed changes
Copy link
Collaborator

@raj-prince raj-prince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requires discussion.

@raj-prince raj-prince self-requested a review May 21, 2024 04:58
@raj-prince raj-prince dismissed their stale review May 21, 2024 05:03

By mistake approved (thought it's a different PR), this requires a discussion.

ankitaluthra1
ankitaluthra1 requested changes May 21, 2024
View reviewed changes
internal/storage/storage_handle.go Outdated Show resolved Hide resolved
internal/gcsx/bucket_manager.go Outdated Show resolved Hide resolved
internal/storage/bucket_handle.go Outdated Show resolved Hide resolved
internal/storage/bucket_handle.go Outdated Show resolved Hide resolved
internal/storage/bucket_handle_test.go Show resolved Hide resolved
internal/storage/bucket_handle.go Outdated Show resolved Hide resolved
internal/storage/bucket_handle.go Outdated Show resolved Hide resolved
@Tulsishah Tulsishah force-pushed the implement_method_to_return_bucket_type branch from dd527d5 to 5988e11 Compare May 21, 2024 07:50
@Tulsishah Tulsishah added execute-integration-tests Run only integration tests and removed execute-integration-tests Run only integration tests labels May 21, 2024
@Tulsishah Tulsishah force-pushed the implement_method_to_return_bucket_type branch from e5f37ff to 104e8f4 Compare May 22, 2024 04:45
@Tulsishah Tulsishah force-pushed the implement_method_to_return_bucket_type branch from 8b1819b to efdc715 Compare May 22, 2024 04:51
ankitaluthra1
ankitaluthra1 previously approved these changes May 22, 2024
View reviewed changes
Copy link
Collaborator

@ankitaluthra1 ankitaluthra1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Tulsishah Tulsishah requested a review from raj-prince May 22, 2024 10:04
raj-prince
raj-prince reviewed May 22, 2024
View reviewed changes
Copy link
Collaborator

@raj-prince raj-prince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Went through with the interface level change. Added a couple of comments.

@Tulsishah Tulsishah requested a review from raj-prince May 22, 2024 15:21
ankitaluthra1
ankitaluthra1 previously approved these changes May 23, 2024
View reviewed changes
Copy link
Collaborator

@ankitaluthra1 ankitaluthra1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

internal/storage/gcs/bucket.go Show resolved Hide resolved
raj-prince
raj-prince approved these changes May 25, 2024
View reviewed changes
Copy link
Collaborator

@raj-prince raj-prince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Relying on Ankita's review for unit test changes.

@Tulsishah Tulsishah merged commit d4cce5d into master May 27, 2024
13 checks passed
@BrewTestBot BrewTestBot mentioned this pull request May 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raj-prince raj-prince raj-prince approved these changes

@ankitaluthra1 ankitaluthra1 ankitaluthra1 left review comments

Assignees
No one assigned
Labels
execute-integration-tests Run only integration tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Tulsishah @raj-prince @ankitaluthra1