Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch unavailable remote download URLs before they hit the filefetcher #4142

Draft
wants to merge 4 commits into
base: 2.x
Choose a base branch
from

Conversation

janette
Copy link
Member

@janette janette commented Mar 6, 2024

When creating a dataset distribution with a remote file that is invalid or not yet available, user will get an error when the localize_import queue runs:

[error]  Error: Call to a member function setupState() on null in FileFetcher\FileFetcher->runIt() (line 106 of /var/www/html/vendor/getdkan/file-fetcher/src/FileFetcher.php) #0 /var/www/html/vendor/getdkan/procrastinator/src/Job/Job.php(43): FileFetcher\FileFetcher->runIt()

QA Steps

  • Enable dblog
  • Create a dataset with a remote url distribution, enter a non-existing url into the field and save
  • Run drush queue:run localize_import
  • Confirm there are no errors to the screen
  • Check the logs
  • Confirm you see a message stating the url provided can not be reached.

@janette janette marked this pull request as draft March 12, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants