Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enum values in schema.json vs schema.ui.json (#4041) #4042

Open
wants to merge 2 commits into
base: 2.x
Choose a base branch
from
Open

enum values in schema.json vs schema.ui.json (#4041) #4042

wants to merge 2 commits into from

Conversation

stefan-korn
Copy link
Contributor

@stefan-korn stefan-korn commented Oct 23, 2023 •
edited

fixes #4041

  • Test coverage exists
  • Documentation exists

QA Steps

  • Add the following to dataset.ui.json at "accessLevel" -> "ui:options"
      "widget": "list",
      "type": "select_other"

see that access level will now generate a "select other" widget with the options from the enum from dataset.json

janette
janette requested changes Dec 8, 2023
View reviewed changes
Copy link
Member

@janette janette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stefan-korn can you make this: if (isset($spec->source)) {

@stefan-korn
Copy link
Contributor Author

@janette : Thanks, change makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janette janette janette requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

enum values in schema.json vs schema.ui.json
2 participants
@stefan-korn @janette