Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of percentages from fetch/import jobs and dashboard #3998

Open
wants to merge 2 commits into
base: 2.x
Choose a base branch
from

Conversation

kaise-lafrai
Copy link
Contributor

@kaise-lafrai kaise-lafrai commented Aug 10, 2023

fixes [org/repo/WCMS-11950]

  • Test coverage exists
  • Documentation exists

QA Steps

  • Pull branch down to your local for testing
  • Create new dataset @ /node/add/data
  • Navigate to dashboard @ /admin/dkan/datastore/status
  • Confirm new row exists for the new dataset
  • Confirm Fetch column displays status only and does not display the percentage done
  • Confirm Store column displays status only and does not display the percentage done
  • VIA terminal run the following drush command ddev drush dkan:datastore:list
  • Confirm that the FileFetcher and Importer columns do not display percentages done.
  • Run ddev dkan-phpunit and confirm tests pass.

@kaise-lafrai kaise-lafrai marked this pull request as ready for review August 10, 2023 18:46
@kaise-lafrai kaise-lafrai changed the title Removed import info percentages Removal of percentages from fetch/import jobs and dashboard Aug 10, 2023
@jastraat
Copy link
Contributor

I thought we were going to leave the import percentage complete since that is used by PDC since we're still using the chunking importer...?

@kaise-lafrai
Copy link
Contributor Author

I thought we were going to leave the import percentage complete since that is used by PDC since we're still using the chunking importer...?

I should probably close this PR since we decided not to remove the percentages. Thanks @jastraat

@janette janette reopened this Dec 1, 2023
@jastraat
Copy link
Contributor

Just to add this here, our team used the import percentages just last week -

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants