[Fixes #7535] Issues with .env GEOSERVER_ADMIN_PASSWORD #9911
Conversation
* geoserver admin password is only changed from the default during init * geoserver has to be manually updated for subsequent password changes * drop redundant OGC_SERVER_DEFAULT_PASSWORD/OGC_SERVER_DEFAULT_USER variables
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @jthurner on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added. |
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @jthurner on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added. |
Codecov Report
@@ Coverage Diff @@
## master #9911 +/- ##
==========================================
- Coverage 61.39% 61.38% -0.01%
==========================================
Files 823 823
Lines 50328 50328
Branches 7746 7746
==========================================
- Hits 30898 30896 -2
- Misses 17753 17756 +3
+ Partials 1677 1676 -1 |
|
| GitGuardian id | Secret | Commit | Filename | |
|---|---|---|---|---|
| - | Django Secret Key | 63f1c8d | .env.sample | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
|
@jthurner your CLA is missing: https://github.com/GeoNode/geonode/blob/master/CONTRIBUTING.md |
|
This PR may have become superseded. It seems that the fixture to change the geoserver password got removed completely. This is actually good, as this raised so many issues. @afabiani as you did the change, you should decide on this issue. What about all the other open issues targeting the same problem? I did a quick naive search and have the impression that a lot of them originate to the same problem. |
When initializing the geonode stack with docker, the password for the geoserver admin user is changed from the default to the value of $GEOSERVER_ADMIN_PASSWORD. Subsequent password changes require manual intervention to update the password in geoserver (even if FORCE_REINIT=true).
OGC_SERVER_DEFAULT_PASSWORD and OGC_SERVER_DEFAULT_USER are redundant as they always took the value of GEOSERVER_ADMIN_PASSWORD/GEOSERVER_ADMIN_USER if defined, replaced with GEOSERVER_ADMIN_PASSWORD/GEOSERVER_ADMIN_USER to avoid confusion.
Corresponding issues in geonode-project:
Checklist
For all pull requests:
The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):
Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.