Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixes #12229] tinymce is not visible after the upgrade to v4 #12230

Merged
merged 1 commit into from
May 15, 2024

Conversation

mattiagiupponi
Copy link
Contributor

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • This PR passes the QA checks: black geonode && flake8 geonode
  • Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates
  • Commits adding new texts do use gettext and have updated .po / .mo files (without location infos)

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@mattiagiupponi mattiagiupponi added this to the 4.3.0 milestone May 15, 2024
@mattiagiupponi mattiagiupponi self-assigned this May 15, 2024
@cla-bot cla-bot bot added the cla-signed CLA Bot: community license agreement signed label May 15, 2024
@mattiagiupponi mattiagiupponi added backport 4.3.x backport to 4.3.x and removed cla-signed CLA Bot: community license agreement signed labels May 15, 2024
@mattiagiupponi mattiagiupponi linked an issue May 15, 2024 that may be closed by this pull request
Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.01%. Comparing base (ffde050) to head (58d69b6).

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #12230   +/-   ##
=======================================
  Coverage   64.01%   64.01%           
=======================================
  Files         870      870           
  Lines       52221    52221           
  Branches     6487     6487           
=======================================
  Hits        33431    33431           
  Misses      17289    17289           
  Partials     1501     1501           

@giohappy giohappy merged commit 73055bd into master May 15, 2024
19 checks passed
@giohappy giohappy deleted the ISSUE_12229 branch May 15, 2024 15:07
Copy link
Contributor

The backport to 4.3.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-4.3.x 4.3.x
# Navigate to the new working tree
cd .worktrees/backport-4.3.x
# Create a new branch
git switch --create backport-12230-to-4.3.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 73055bde345622d4c12abb3ebc2e3eec7750d191
# Push it to GitHub
git push --set-upstream origin backport-12230-to-4.3.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-4.3.x

Then, create a pull request where the base branch is 4.3.x and the compare/head branch is backport-12230-to-4.3.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 4.3.x backport to 4.3.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tinymce text area are not visible after the upgrade to v4
2 participants