4.2.x issue #12170 unable to set advanced contact roles in metadata editor

[mwallschlaeger]

ref #12170

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

• Confirm you have read the contribution guidelines
• You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
• Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

• There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
• The issue connected to the PR must have Labels and Milestone assigned
• PR for bug fixes and small new features are presented as a single commit
• Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
• New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented
• This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
• This PR passes the QA checks: black geonode && flake8 geonode
• Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates
• Commits adding new texts do use gettext and have updated .po / .mo files (without location infos)

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

[codecov]

Codecov Report

Attention: Patch coverage is 90.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 63.18%. Comparing base (567191c) to head (802f35f).

Additional details and impacted files

@@           Coverage Diff           @@
##            4.2.x   #12191   +/-   ##
=======================================
  Coverage   63.17%   63.18%           
=======================================
  Files         877      877           
  Lines       52551    52551           
  Branches     6596     6597    +1     
=======================================
+ Hits        33200    33205    +5     
+ Misses      17828    17825    -3     
+ Partials     1523     1521    -2     

[cla-bot]

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Marcel Wallschlaeger.
This is most likely caused by a git client misconfiguration; please make sure to:

1. check if your git client is configured with an email to sign commits git config --list | grep email
2. If not, set it up using git config --global user.email email@example.com
3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

[giohappy]

@mwallschlaeger I don't know what happened but it looks like tests are failing now. They looked good a few days ago.
Can you please check?

[mwallschlaeger]

@giohappy i have seen the bad test results after my last, commit but i comprehend. Could you restart the tests pls

[giohappy]

@mwallschlaeger I'm closing this in favor of #12207 since I could make the tests pass by creating a new PR. I also took the opportunity to bump the client and importer dependencies.