Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixes #11703] Documents can now be uploaded without specifying title via the REST API. #11872

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

ahmdthr
Copy link
Contributor

@ahmdthr ahmdthr commented Jan 22, 2024

Fixes#11703 Upload document via REST API v2 does not work

The document upload does not work without specifying the title. With this PR the document will be uploaded while setting the title as the name of the uploaded file.

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • This PR passes the QA checks: black geonode && flake8 geonode
  • Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates
  • Commits adding new texts do use gettext and have updated .po / .mo files (without location infos)

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@cla-bot cla-bot bot added the cla-signed CLA Bot: community license agreement signed label Jan 22, 2024
Copy link

codecov bot commented Jan 22, 2024

Codecov Report

Merging #11872 (87510d5) into master (9d6a246) will increase coverage by 0.00%.
The diff coverage is 92.30%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #11872   +/-   ##
=======================================
  Coverage   63.49%   63.49%           
=======================================
  Files         866      866           
  Lines       52508    52520   +12     
  Branches     6599     6600    +1     
=======================================
+ Hits        33339    33348    +9     
- Misses      17653    17656    +3     
  Partials     1516     1516           

@ahmdthr ahmdthr marked this pull request as ready for review January 30, 2024 05:56
@mattiagiupponi mattiagiupponi changed the title Documents can now be uploaded without specifying title via the REST API. [Fixes #11703] Documents can now be uploaded without specifying title via the REST API. Feb 2, 2024
@giohappy giohappy self-requested a review February 2, 2024 15:32
@giohappy
Copy link
Contributor

giohappy commented Feb 2, 2024

@ahmdthr please take a look at the failing tests.

Copy link
Contributor

@giohappy giohappy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently your test is failing

@ahmdthr
Copy link
Contributor Author

ahmdthr commented Feb 12, 2024

Apparently your test is failing

Sorry for the late response, but I was sick last week. I am going to fix the issues today. Thank you for waiting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed CLA Bot: community license agreement signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants