[Fixes #12124] GNIP 100: Assets - cleanup tmp doc file

geonode/assets/utils.py

@@ -72,7 +72,9 @@ def create_asset_and_link(
     asset = link = None
     try:
         default_title, default_ext = os.path.splitext(files[0]) if len(files) == 1 else (None, None)
-        link_type = link_type or find_type(default_ext[1:]) if default_ext else None
+        if default_ext:
+            default_ext = default_ext.lstrip(".")
+        link_type = link_type or find_type(default_ext) if default_ext else None
 
         asset = asset_handler.create(
             title=title or default_title or "Unknown",

geonode/documents/views.py

@@ -179,8 +179,13 @@ def form_valid(self, form):
                     files=[storage_path],
                 ),
             )
-            if tempdir != os.path.dirname(storage_path):
-                shutil.rmtree(tempdir, ignore_errors=True)
+
+            # Removing the temp file
+            # TODO: creating a file and then cloning it as an Asset may be slow: we may want to
+            #       create the file directly in the asset dir or to move it
+            logger.info(f"Removing document temp dir {tempdir}")
+            shutil.rmtree(tempdir, ignore_errors=True)
+
         else:
             self.object = resource_manager.create(
                 None,