Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use base images #493

Merged
merged 2 commits into from
Oct 12, 2023
Merged

Use base images #493

merged 2 commits into from
Oct 12, 2023

Conversation

giohappy
Copy link
Contributor

@giohappy giohappy commented Oct 10, 2023

This is one of the steps in the refactoring of the Docker configurations for GeoNode and GeoNode Project.
The project will use the base images built from https://github.com/GeoNode/geonode-docker and pushed to the Hub.
For the master branch all the images all tagged as latest

Copy link

@ridoo ridoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. However, I built it and what bothers me still is the installation of geonode-mapstore-client. This is a really huge repository (about 1GB) an pip is not able to clone a shallow working copy.

I think it would make sense to remove the compiled JS stuff from the repo, and only build and include it into a release build. This, however, would be separate issue of course. What do you think?

@giohappy
Copy link
Contributor Author

@ridoo we also investigated the problem of pip installing the submodules automatically. Of course, this only affects the master branch, since the tagged versions use the PiPi package (where all source files are stripped).

A solution, as suggested also in the StackOverflow you mention, is to make pip use an archive file. We could create a workflow that builds the package for each commit to the master branch, but we don't have time for it at the moment.
Anyway, yes, this is for another issue :)

@giohappy giohappy merged commit 1b50a71 into master Oct 12, 2023
4 checks passed
@giohappy giohappy deleted the use_base_images branch October 12, 2023 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants