Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local buids opt-in #473

Closed
wants to merge 4 commits into from
Closed

Local buids opt-in #473

wants to merge 4 commits into from

Conversation

giohappy
Copy link
Contributor

docker-compose-local-builds.yml can be used an override to build from local Dockerfiles

@giohappy giohappy requested a review from afabiani August 29, 2023 13:36
@giohappy giohappy changed the title Local buidds optin Local buids opt-in Aug 29, 2023
@giohappy giohappy requested a review from ridoo August 30, 2023 10:30
Copy link

@ridoo ridoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of adding an additional docker-compose-local-builds.yml you could add a Dockerfile for each component which just includes FROM <base_image> and put a build: ./docker/<component> in the normal docker-compose.yml.

We did this in our proposal for Docker re-organization. For example:

docker-compose.yml:
https://github.com/52North/geonode-project/blob/centralize_docker_images/docker-compose.yml#L8-L11

Dockerfile:
https://github.com/52North/geonode-project/blob/centralize_docker_images/docker/geonode/Dockerfile#L1-L2

@giohappy
Copy link
Contributor Author

Instead of adding an additional docker-compose-local-builds.yml you could add a Dockerfile for each component which just includes FROM <base_image> and put a build: ./docker/ in the normal docker-compose.yml.

Sounds good @ridoo. Indeed this is the benefit of using Docker multi-state builds. I'm going to read the other proposal ASAP

@giohappy giohappy marked this pull request as draft August 30, 2023 15:06
@giohappy giohappy closed this Mar 27, 2024
@giohappy giohappy deleted the local_buidds_optin branch March 27, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants