Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fixes #233] [GPKG] must specify native_crs #234

Merged
merged 6 commits into from May 3, 2024
Merged

[Fixes #233] [GPKG] must specify native_crs #234

merged 6 commits into from May 3, 2024

Conversation

mattiagiupponi
Copy link
Contributor

ref #233

@mattiagiupponi mattiagiupponi requested a review from etj April 17, 2024 10:31
@mattiagiupponi mattiagiupponi self-assigned this Apr 17, 2024
@mattiagiupponi mattiagiupponi linked an issue Apr 17, 2024 that may be closed by this pull request
[GPKG] "must specify native_crs" #233
Closed
@giohappy
Copy link
Contributor

@mattiagiupponi this funcationality, and related changes, should be covered by tests. Don't we have them?

@mattiagiupponi
Copy link
Contributor Author

mattiagiupponi commented Apr 17, 2024 •
edited

@mattiagiupponi this funcationality, and related changes, should be covered by tests. Don't we have them?

we should have test for the import_resource. I'll add a test do verify this
I though i open this as draft, i wanted a feedback from @etj about the possible fix.
I'll move it to draft.

@mattiagiupponi mattiagiupponi marked this pull request as draft April 17, 2024 12:33
@mattiagiupponi mattiagiupponi marked this pull request as ready for review May 2, 2024 08:26
@mattiagiupponi mattiagiupponi merged commit 658a825 into master May 3, 2024
2 checks passed
@mattiagiupponi mattiagiupponi deleted the ISSUE_233 branch May 3, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giohappy giohappy giohappy approved these changes

@etj etj Awaiting requested review from etj

Assignees

@mattiagiupponi mattiagiupponi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[GPKG] "must specify native_crs"
2 participants
@mattiagiupponi @giohappy