-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add mus-ignore-yosys-internal-netnames option #1
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, I left a couple minor comments.
The only high-level thought I have is that it might be nice to add clarity somewhere (I'm not sure where it belongs) about what is meant by an 'internal' name. I think even three sentences like the following could be very helpful to future people:
This engine is augmented to map SMT identifiers in the MUS's back to source-level RTL identifiers (e.g., wires and registers in SystemVerilog). During synthesis, Yosys creates additional identifiers, prefixed by
$
, that do not have a source-level correspondent. We refer to these identifers as 'internal.'
It might seem obvious and verbose now, but could be valuable for future people trying to understand the code.
This prevents needing to pass a boolean flag to disable the option
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks for addressing the previous small bits of feedback and good catch on the flag issue.
Add an option for the MUS engine to not include constraints associated with yosys internal netnames (those with '$'-prefixed names) in the MUS constraint set.