-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring to support control sync rework #387
Draft
danmatichuk
wants to merge
18
commits into
master
Choose a base branch
from
dm/control_sync_wip2
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes issue where GUI would hang when trying to navigate to display a choice tree (i.e. prompt)
this is a forward-looking change to support more expressive control flow synchronization
this is an intermediate step in adding additional ways that a node can be queued to be processed - in particular, handling node merge logic via the scheduler
This clears up some of the ambiguity in the SyncPoint data which otherwise had lots of implicit assumptions about the run-time contents of the NodeEntry for each sync point A SingleNodeEntry is functionally equivalent to a NodeEntry that's annotated with the fact that it's single-sided
…r patched this is essentially the same as Const, but useful for cases where we want to establish OrdF or TestEquality
this now builds, and changes the control flow synchronization to occur as a first-class operation that is explicitly scheduled this provides some flexibility for handling additional cases for mismatched control flow, but this is still work in progress
appropriately merged
Closed
this allows us to handle the "zero step" sync case explicitly, where one of the sides of the analysis takes no steps before re-synchronizing control flow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.