Abstract binary container format #110
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change doesn't compile. This is trying to make the core of the verifier agnostic to the binary format (currently fixed as ELF). This was almost working, except for the complex code that handles the PowerPC TOC. That logic will really need to be refactored first. The explicit reliance on the TOC means that we actually have to deal with the `binFmt` type parameter somehow, which really complicates any change like this. It is currently handled by fixing that parameter to ELF everywhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change doesn't compile. This is trying to make the core of the verifier
agnostic to the binary format (currently fixed as ELF). This was almost working,
except for the complex code that handles the PowerPC TOC. That logic will really
need to be refactored first.
The explicit reliance on the TOC means that we actually have to deal with the
binFmttype parameter somehow, which really complicates any change likethis. It is currently handled by fixing that parameter to ELF everywhere.