Miscellaneous fixes #25
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Move cabal-version to the start of the file
libcurl has always used size_t for buffer sizes but using the correct Haskell type matters more now because sizeof(int) /= sizeof(size_t) on 64-bit.
|
Thanks for this! Was scratching my head quite a bit where these inconsistent errors were coming from. |
sternenseemann
added a commit
to sternenseemann/spacecookie
that referenced
this pull request
Sep 22, 2022
See also GaloisInc/curl#25, seems to be a relatively recent development.
sternenseemann
added a commit
to sternenseemann/spacecookie
that referenced
this pull request
Sep 22, 2022
See also GaloisInc/curl#25, seems to be a relatively recent development.
|
Any chance of getting this merged, please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes fixes to documentation, the cabal file, and the datatypes used in callback functions.
The most important change is adding a warning about needing to use the threaded runtime. It took me quite a few hours of debugging to find out why
libcurlwas returning a highly misleading error (CurlBadFunctionArgument) due to being interrupted by aSIGVTALRMfrom the non-threaded runtime.