Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carry bytesRead over calls to lookAhead (addresses issue #93) #98

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jmazon
Copy link

@jmazon jmazon commented Sep 15, 2021

And then I compared to binary and got very confused as to why we have both.

Anyway, the “lookAheads don't advance bytesRead” behavior makes a lot more sense to me, so if that suits the project, here's a patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant