260 add automatic processing of detected markings #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhhd2020
force-pushed
the
260-add-automatic-processing-of-detected-markings
branch
from
ef5feb7
to
0bd1ad2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code has been refactored and the QGIS scripts and the script for heatmap generation could perhaps also be offered for download along with instructions independent of whether they are used in the backend.
To avoid that the marking detection has to run twice for both celery tasks (vector results and overlap count result), a chain has been introduced.
Manual system tests have shown that everything works as it should and the new heatmap generation and QGIS project output function as expected.
As it has been discussed in recent meetings to avoid using QGIS in the backend, I will leave this PR as is. In case it is worked on in the future, open To Dos are: