Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: areaOfInterest should not override previously set bbox #512

Merged
merged 1 commit into from
Aug 31, 2023
Merged

bugfix: areaOfInterest should not override previously set bbox #512

merged 1 commit into from
Aug 31, 2023

Conversation

tyrasd
Copy link
Member

@tyrasd tyrasd commented Aug 31, 2023

instead, it should use the intersection of the previously set bbox and the "incoming" one, to be consistent with all "filters" work on a mapreducer.

@tyrasd tyrasd added bug Something isn't working as expected priority:low Should be quite a far way down on the agenda labels Aug 31, 2023
@tyrasd tyrasd requested a review from rtroilo August 31, 2023 10:15
rtroilo
rtroilo approved these changes Aug 31, 2023
View reviewed changes
Copy link
Member

@rtroilo rtroilo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you, lgtm

@tyrasd tyrasd merged commit 22aef0e into master Aug 31, 2023
7 checks passed
@tyrasd tyrasd deleted the fix-multiple-bbox-aoi branch August 31, 2023 11:18
ConstantinNicolai pushed a commit that referenced this pull request Oct 11, 2023
@tyrasd @ConstantinNicolai
fix: areaOfInterest should not override previously set bbox (#512)
bf2bdc7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rtroilo rtroilo rtroilo approved these changes

Assignees
No one assigned
Labels
bug Something isn't working as expected priority:low Should be quite a far way down on the agenda
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tyrasd @rtroilo