feat: Add experimental cargo bike profile #1744
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* First changes * second part * Third part * Changes for junction * Implement availability of junction tags Junctions are not handled by ORS. They need to be implemented and tested, similar to how Tollways are handled. - Create a new type for junctions (JunctionType.java) - Create an Extractor to fetch junctions (JunctionExtractor.java) - Create a place to store junctions (JunctionGraphStorage.java) - To create a storage implement a StorageBuilder (JunctionGraphStorageBuilder.java) - Add junction tag in other necessary places (APIEnums| AvoidFeaturesEdgeFilter | ...) - Remove Tollways from "ors-engine/src/main/resources/META-INF/services/org.heigit.ors.routing.graphhopper.extensions.storages.builders.GraphStorageBuilder" - Add tests for new files (JunctionGraphStorageBuilderTest.java) * Modify route visualization w/ folium * Copy green_streets_hd.csv file and build graph * Add more routes to apicaller.ipynb * Add cycling infrastructure on small streets * Remove special character * Set-up for aws environment * Update .dockerignore * Update .dockerignore * Update .dockerignore * Update .gitignore * Update ors-config.json * Update .rpm-packaging/ors-config.json * Delete .vscode/settings.json * Update docker-compose.yml * Update docker-compose.yml * Update docker-compose.yml * Update docker-compose.yml * Update .dockerignore * Delete modified.sh * Update ors-config.yml * Update ors-config.yml * Update ors-config.yml * Update ors-api/src/test/java/org/heigit/ors/api/services/RoutingServiceTest.java * Update ors-api/src/test/java/org/heigit/ors/api/services/RoutingServiceTest.java * Update ors-engine/src/main/java/org/heigit/ors/routing/RoutingProfile.java * Update ors-engine/src/main/java/org/heigit/ors/routing/graphhopper/extensions/OSMTags.java * Update ors-engine/src/main/java/org/heigit/ors/routing/graphhopper/extensions/OSMTags.java * Delete requirements.txt * Apply suggestions from code review * Delete subprocess.sql * Delete testtools/requirements.txt * Delete testtools/apicaller.ipynb * Update ors-config.json * Update ors-config.json * Update ors-config.yml * Update .dockerignore * Apply suggestions from code review * Update APIEnums.java * Update RequestProfileParamsWeightings.java * Update .dockerignore
|
@jan-bausch Hi and welcome. Thanks for opening a PR for a cargo bike profile. Interesting. If it is a still in progress, please switch to a PR draft first and let's have some discussion around it. Cheers! |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
have been resolved.
[Unreleased] heading.
along with a short description of what it is for, and documented this in the Pull Request (below).
(at least Germany), and the graphs build without problems (i.e. no out-of-memory errors).
importer etc.), I have generated longer distance routes for the affected profiles with different options
(avoid features, max weight etc.) and compared these with the routes of the same parameters and start/end
points generated from the current live ORS.
If there are differences then the reasoning for these MUST be documented in the pull request.
and why the change was needed.
Fixes # .
Information about the changes
Examples and reasons for differences between live ORS routes, and those generated from this pull request
Required changes to ors config (if applicable)