Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: versioning for documentation #1704

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Conversation

jarinox
Copy link

@jarinox jarinox commented Feb 28, 2024

Pull Request Checklist

  • 1. I have rebased the latest version of the main branch into my feature branch and all conflicts
    have been resolved.
  • 2. I have added information about the change/addition to functionality to the CHANGELOG.md file under the
    [Unreleased] heading.
  • 3. I have documented my code using JDocs tags.
  • 4. I have removed unnecessary commented out code, imports and System.out.println statements.
  • 5. I have written JUnit tests for any new methods/classes and ensured that they pass.
  • 6. I have created API tests for any new functionality exposed to the API.
  • 7. If changes/additions are made to the ors-config.json file, I have added these to the ors config documentation
    along with a short description of what it is for, and documented this in the Pull Request (below).
  • 8. I have built graphs with my code of the Heidelberg.osm.gz file and run the api-tests with all test passing
  • 9. I have referenced the Issue Number in the Pull Request (if the changes were from an issue).
  • 10. For new features or changes involving building of graphs, I have tested on a larger dataset
    (at least Germany), and the graphs build without problems (i.e. no out-of-memory errors).
  • 11. For new features or changes involving the graphbuilding process (i.e. changing encoders, updating the
    importer etc.), I have generated longer distance routes for the affected profiles with different options
    (avoid features, max weight etc.) and compared these with the routes of the same parameters and start/end
    points generated from the current live ORS.
    If there are differences then the reasoning for these MUST be documented in the pull request.
  • 12. I have written in the Pull Request information about the changes made including their intended usage
    and why the change was needed.
  • 13. For changes touching the API documentation, I have tested that the API playground renders correctly.

Fixes # .

Information about the changes

  • Key functionality added: Versioning for documentation

This adds the vitepress-versioning-plugin and refactors the docs to work together with this plugin. All absolute internal links have been changed to relative links. The vitepress configuration has been updated to work with this plugin.

How to add a new version

  • Create the folder docs/versions/{lastVersion} and copy the documentation of the last version into it.
  • Use cp docs/.vitepress/sidebars/versioned/template.json docs/.vitepress/sidebars/versioned/{lastVersion}.json to create a sidebar for the new version. Manually change the sidebar if needed.

@takb takb added this to To do in ors general Feb 28, 2024
@jarinox jarinox changed the title Versioning for documentation docs: versioning for documentation Feb 28, 2024
Jakob Stolze added 4 commits February 28, 2024 16:14
- refactor sidebar as plugin requires sidebars to strictly conform with the specs
The versioning plugin only works with relative links as absolute links
would always point to the latest version.
See IMB11/vitepress-versioning-plugin#2
Sidebars have to be defined for each version. This adds a JSON file
which can be copied to create set the current sidebar to future
versions.
@jarinox jarinox marked this pull request as ready for review February 28, 2024 15:14
@koebi koebi self-requested a review February 28, 2024 15:20
@MichaelsJP MichaelsJP marked this pull request as draft March 7, 2024 17:14
Copy link

sonarcloud bot commented Mar 18, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
ors general
  
To do
Development

Successfully merging this pull request may close these issues.

None yet

1 participant