fix: gpx response not returned correctly #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the text response from the gpx endpoint was also retrieved through the .json function of the Response object which threw an error as it was not possible to parse the gpx to json. For gpx it now uses the .text function instead and just returns the gpx result as a string.
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #75 +/- ##
=======================================
Coverage 99.09% 99.09%
=======================================
Files 15 15
Lines 331 331
Branches 57 57
=======================================
Hits 328 328
Misses 3 3
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the text response from the gpx endpoint was also retrieved through the .json function of the Response object which threw an error as it was not possible to parse the gpx to json.
For gpx it now uses the .text function instead and just returns the gpx result as a string.