replace bluebird promises with async/await & superagent with native fetch #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #63 +/- ##
==========================================
+ Coverage 94.24% 97.09% +2.84%
==========================================
Files 16 16
Lines 365 344 -21
Branches 67 58 -9
==========================================
- Hits 344 334 -10
+ Misses 19 9 -10
+ Partials 2 1 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
EmmaHegarty
force-pushed
the
native-promise
branch
5 times, most recently
from
eab7729
to
c686b0f
Compare
EmmaHegarty
force-pushed
the
native-promise
branch
from
c686b0f
to
926ab05
Compare
EmmaHegarty
force-pushed
the
native-promise
branch
2 times, most recently
from
76c4eea
to
5ad89ac
Compare
This was
linked to
issues
Mar 21, 2023
EmmaHegarty
force-pushed
the
native-promise
branch
2 times, most recently
from
76c4eea
to
8d35c1b
Compare
instead of defining Promises we are now using async-await-syntax to handle promises.
- fetch() only rejects network errors, other errors need to be thrown manually by checking response.ok
- inline return
- throw Error instead of object (old also threw error)
- error now contains fetch Response which still can be consumed
BREAKING-CHANGE: Response object from Error is not superagent
but fetch response type (https://developer.mozilla.org/en-US/docs/Web/API/Response)
that can still be consumed
Co-authored-by: Amandus Butzer <amandus.butzer@heigit.org>
TheGreatRefrigerator
force-pushed
the
native-promise
branch
from
8d35c1b
to
7ff3bd7
Compare
- test missing layers parameter in geocode - use cy.intercept instead of actual API request - test missing format parameter in directions
- showcase try-catch + async-await syntax instead of .then chaining - add example on how to connect ot local ors instance
TheGreatRefrigerator
force-pushed
the
native-promise
branch
from
7ff3bd7
to
ad479aa
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
TheGreatRefrigerator
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removes dependency on bluebird and superagent, solves #61 and #64