Merge pull request #70 from GIScience/refactor/BREAKING-remove-unused…

…-functions

Refactor/breaking remove unused functions

README.md

@@ -167,7 +167,6 @@ Geocode.geocode({
   console.log(str)
 })
 
-Geocode.clear()
 
 Geocode.reverseGeocode({
   point: { lat_lng: [49.412388, 8.681247], radius: 50 },
@@ -181,7 +180,6 @@ Geocode.reverseGeocode({
   console.log(str);
 })
 
-Geocode.clear()
 
 Geocode.structuredGeocode({
   locality: "Heidelberg"

src/OrsDirections.js

@@ -12,23 +12,6 @@ class OrsDirections extends OrsBase {
     }
   }
 
-  clear() {
-    for (const variable in this.defaultArgs) {
-      if (variable !== Constants.propNames.apiKey) delete this.defaultArgs[variable]
-    }
-  }
-
-  clearPoints() {
-    if ('coordinates' in this.defaultArgs) this.defaultArgs.coordinates.length = 0
-  }
-
-  addWaypoint(latLon) {
-    if (!('coordinates' in this.defaultArgs)) {
-      this.defaultArgs.coordinates = []
-    }
-    this.defaultArgs.coordinates.push(latLon)
-  }
-
   getBody(args) {
     if (args.options && typeof args.options !== 'object') {
       args.options = JSON.parse(args.options)

src/OrsElevation.js

@@ -4,13 +4,7 @@ import Constants from './constants.js'
 import OrsBase from './OrsBase.js'
 
 const orsUtil = new OrsUtil()
-
 class OrsElevation extends OrsBase {
-  clear() {
-    for (const variable in this.defaultArgs) {
-      if (variable !== Constants.propNames.apiKey) delete this.defaultArgs[variable]
-    }
-  }
 
   generatePayload(args) {
     const payload = {}

src/OrsGeocode.js

@@ -105,12 +105,6 @@ class OrsGeocode extends OrsBase {
     }
   }
 
-  clear() {
-    for (const variable in this.defaultArgs) {
-      if (variable !== Constants.propNames.apiKey) delete this.defaultArgs[variable]
-    }
-  }
-
   getParametersAsQueryString(args) {
     let queryString = ''
     for (const key in args) {

src/OrsIsochrones.js

@@ -12,13 +12,6 @@ class OrsIsochrones extends OrsBase {
     }
   }
 
-  addLocation(latlon) {
-    if (!('locations' in this.defaultArgs)) {
-      this.defaultArgs.locations = []
-    }
-    this.defaultArgs.locations.push(latlon)
-  }
-
   getBody(args) {
     const options = {}
 

src/OrsOptimization.js

@@ -6,12 +6,6 @@ import OrsBase from "./OrsBase.js"
 const orsUtil = new OrsUtil()
 
 class OrsOptimization extends OrsBase {
-  clear() {
-    for (let variable in this.defaultArgs) {
-      if (variable !== Constants.propNames.apiKey) delete this.defaultArgs[variable]
-    }
-  }
-
   generatePayload(args) {
     let payload = {}
 

src/OrsPois.js

@@ -13,12 +13,6 @@ class OrsPois extends OrsBase {
     }
   }
 
-  clear() {
-    for (const variable in this.defaultArgs) {
-      if (variable !== Constants.propNames.apiKey) delete this.defaultArgs[variable]
-    }
-  }
-
   generatePayload(args) {
     const payload = {}
 

src/__tests__/OrsDirections.cy.js

@@ -109,39 +109,4 @@ describe('Test Directions', () => {
       })
     })
   })
-
-  context('unused functions', () => {
-    it('clear() clears everything but API key', () => {
-      orsDirections.defaultArgs = {
-        variable1: 'v1',
-        api_key: 'API key'
-      }
-      orsDirections.clear()
-      expect(orsDirections.defaultArgs).to.deep.equal({api_key: 'API key'})
-    })
-
-    it('clearPoints() clears only coordinates', () => {
-      orsDirections.defaultArgs = {
-        'coordinates': [[8.690958, 49.404662], [8.687868, 49.390139]],
-        'otherArg': [1, 2]
-      }
-      orsDirections.clearPoints()
-      expect(orsDirections.defaultArgs.coordinates.length).to.equal(0)
-      expect(orsDirections.defaultArgs.otherArg.length).to.equal(2)
-    })
-
-    context('addWaypoint', () => {
-      it('addWaypoint() adds coordinates', () => {
-        orsDirections.defaultArgs.coordinates = [[8.690958, 49.404662]]
-        orsDirections.addWaypoint([8.687868, 49.390139])
-        expect(orsDirections.defaultArgs.coordinates.length).to.equal(2)
-      })
-
-      it('addWaypoint() creates property if not existing', () => {
-        orsDirections.defaultArgs = {}
-        orsDirections.addWaypoint()
-        expect(orsDirections.defaultArgs).to.have.property('coordinates')
-      })
-    })
-  })
 })

src/__tests__/OrsElevation.cy.js

@@ -86,15 +86,4 @@ describe('Test Elevation', () => {
       })
     })
   })
-
-  context('unused functions', () => {
-    it('clear() clears everything but API key', () => {
-      orsElevation.defaultArgs = {
-        variable1: 'v1',
-        api_key: 'API key'
-      }
-      orsElevation.clear()
-      expect(orsElevation.defaultArgs).to.deep.equal({api_key: 'API key'})
-    })
-  })
 })

src/__tests__/OrsGeocode.cy.js

@@ -197,16 +197,5 @@ describe('Geocode Test', () => {
       })
     })
   })
-
-  context('unused functions', () => {
-    it('clear() clears everything but API key', () => {
-      orsGeocode.defaultArgs = {
-        variable1: 'v1',
-        api_key: 'API key'
-      }
-      orsGeocode.clear()
-      expect(orsGeocode.defaultArgs).to.deep.equal({api_key: 'API key'})
-    })
-  })
 })
 

src/__tests__/OrsIsochrones.cy.js

@@ -147,26 +147,4 @@ describe('Isochrone Test', () => {
       })
     })
   })
-
-  context('unused functions', () => {
-    context('addLocation', () => {
-      it('adds location to defaultArgs', () => {
-        const orsIsochrones = new OrsIsochrones({ api_key: key })
-        let locations = {
-          locations: [
-            [8.690958, 49.404662],
-            [8.687868, 49.390139]
-          ]}
-        orsIsochrones.defaultArgs = {...orsIsochrones.defaultArgs,...locations}
-        orsIsochrones.addLocation([8.660958, 49.414662])
-        expect(orsIsochrones.defaultArgs.locations.length).to.equal(3)
-      })
-
-      it('adds location to defaultArgs if no location property', () => {
-        const orsIsochrones = new OrsIsochrones({ api_key: key })
-        orsIsochrones.addLocation([8.660958, 49.414662])
-        expect(orsIsochrones.defaultArgs.locations.length).to.equal(1)
-      })
-    })
-  })
 })

src/__tests__/OrsOptimization.cy.js

@@ -102,15 +102,4 @@ describe('Optimization Test', () => {
       })
     })
   })
-
-  context('unused functions', () => {
-    it('clear() clears everything but API key', () => {
-      orsOptimization.defaultArgs = {
-        variable1: 'v1',
-        api_key: 'API key'
-      }
-      orsOptimization.clear()
-      expect(orsOptimization.defaultArgs).to.deep.equal({api_key: 'API key'})
-    })
-  })
 })

src/__tests__/OrsPOIs.cy.js

@@ -61,15 +61,4 @@ describe('POI Test', () => {
       })
     })
   })
-
-  context('unused functions', () => {
-    it('clear() clears everything but API key', () => {
-      orsPois.defaultArgs = {
-        variable1: 'v1',
-        api_key: 'API key'
-      }
-      orsPois.clear()
-      expect(orsPois.defaultArgs).to.deep.equal({api_key: 'API key'})
-    })
-  })
 })