Updating Jenkinsfile for new Jenkins server #742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ConstantinNicolai
added
the
CI
ConstantinNicolai
force-pushed
the
jenkins_update
branch
from
16b80cd
to
8f0eab9
Compare
joker234
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Jenkinsfile used on the old Jenkins server did not work on the new one due to differences in the setup, e.g. the old Jenkins being in a docker container itself and the new one running directly in the OS. The UID and GID for the oqapi user inside the Docker container and the jenkins user in the jenkins workspace had to be matched and we had to mount the jenkins tools directory into the docker container to user sonar scanner.
Checklist
- [ ] I have updated my branch tomain(e.g. throughgit rebase main)- [ ] My code follows the style guide and was checked with pre-commit before committing- [ ] I have commented my code- [ ] I have added sufficient unit and integration tests- [ ] I have updated the CHANGELOG.md