Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add get_template function #673

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat: add get_template function #673

wants to merge 4 commits into from

Conversation

Gigaszi
Copy link
Contributor

@Gigaszi Gigaszi commented Aug 10, 2023

Description

Please add a clear and concise description of what your PR solves.

Corresponding issue

Closes #

New or changed dependencies

Checklist

  • I have updated my branch to main (e.g. through git rebase main)
  • My code follows the style guide and was checked with pre-commit before committing
  • I have commented my code
  • I have added sufficient unit and integration tests
  • I have updated the CHANGELOG.md

Please check all finished tasks. If some tasks do not apply to your PR, please cross their text out (by using ~...~) and remove their checkboxes.

directory = get_module_dir(
"ohsome_quality_analyst.indicators.{}".format(indicator_key)
)
file = glob.glob(directory + "/metadata.yaml", recursive=True)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
file = glob.glob(directory + "/metadata.yaml", recursive=True)
file = os.path.join(directory, "/metadata.yaml")

Should be enough here. Or is it not?

@Gigaszi Gigaszi marked this pull request as ready for review August 22, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants