Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider introducing 'Jakarta Bean validation' standard #46

Open
3 of 6 tasks
mmerdes opened this issue Nov 7, 2023 · 1 comment
Open
3 of 6 tasks

Consider introducing 'Jakarta Bean validation' standard #46

mmerdes opened this issue Nov 7, 2023 · 1 comment

Comments

@mmerdes
Copy link
Collaborator

mmerdes commented Nov 7, 2023 •
edited by ElJocho

  • existing annotation for regexp
  • custom annotation for minimum interval length

Validated Parameters:

  • start and enddate
  • interval
  • topics
  • countries
  • hashtags
  • limit
@mmerdes
Copy link
Collaborator Author

mmerdes commented Nov 7, 2023

as discussed with @ElJocho

mmerdes added a commit that referenced this issue Feb 5, 2024
@mmerdes
refactor: separate validation from controller #46
fdb5db4 
ohsome-contributions-stats-service: 'Consider introducing 'Jakarta Bean validation' standard '
#46
mmerdes added a commit that referenced this issue Feb 5, 2024
@mmerdes
feature: validate every topic on its own with specific error message …
1abd696 
…instead of whole list #46

ohsome-contributions-stats-service: 'Consider introducing 'Jakarta Bean validation' standard '
#46
mmerdes added a commit that referenced this issue Feb 6, 2024
@mmerdes
refactor: cleanup impl #46
5d963a5 
ohsome-contributions-stats-service: 'Consider introducing 'Jakarta Bean validation' standard '
#46
mmerdes added a commit that referenced this issue Feb 6, 2024
@mmerdes
refactor: move controller advice for validation errors up to common s…
be92702 
…uper directory #46

ohsome-contributions-stats-service: 'Consider introducing 'Jakarta Bean validation' standard '
#46
mmerdes added a commit that referenced this issue Feb 6, 2024
@mmerdes
feature: add error message to unparseable interval by using bean vali…
38da13b 
…dation annotation #46

ohsome-contributions-stats-service: 'Consider introducing 'Jakarta Bean validation' standard '
#46
mmerdes added a commit that referenced this issue Feb 6, 2024
@mmerdes
feature: add error message to interval < 1 minute by using bean valid…
c4d2118 
…ation annotation #46

ohsome-contributions-stats-service: 'Consider introducing 'Jakarta Bean validation' standard '
#46
mmerdes added a commit that referenced this issue Feb 7, 2024
@mmerdes
refactor: cleanup impl #46
b945140 
ohsome-contributions-stats-service: 'Consider introducing 'Jakarta Bean validation' standard '
#46
mmerdes added a commit that referenced this issue Feb 7, 2024
@mmerdes
test: consolidate partially redundant error handling tests #46
8d6352f 
ohsome-contributions-stats-service: 'Consider introducing 'Jakarta Bean validation' standard '
#46
mmerdes added a commit that referenced this issue Feb 7, 2024
@mmerdes
feature: add error message to unparseable interval by using bean vali…
b77ad30 
…dation annotation to topic request #46

ohsome-contributions-stats-service: 'Consider introducing 'Jakarta Bean validation' standard '
#46
mmerdes added a commit that referenced this issue Feb 7, 2024
@mmerdes
feature: add error message to interval < 1 minute by using bean valid…
93d3c26 
…ation annotation to topic request #46

ohsome-contributions-stats-service: 'Consider introducing 'Jakarta Bean validation' standard '
#46
mmerdes added a commit that referenced this issue Feb 14, 2024
@mmerdes
test: add (disabled) test for checking date error messaging #46
76c1770 
ohsome-contributions-stats-service: 'Consider introducing 'Jakarta Bean validation' standard '
#46
mmerdes added a commit that referenced this issue Feb 14, 2024
@mmerdes
test: add (disabled) test for checking date error messaging #46
9b6db4d 
ohsome-contributions-stats-service: 'Consider introducing 'Jakarta Bean validation' standard '
#46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mmerdes