feature: add error message to interval < 1 minute by using bean valid…

…ation annotation to topic request #46 ohsome-contributions-stats-service: 'Consider introducing 'Jakarta Bean validation' standard ' #46
GIScience · Feb 7, 2024 · 93d3c26 · 93d3c26
1 parent b77ad30
commit 93d3c26
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/src/main/kotlin/org/heigit/ohsome/now/statsservice/topic/TopicController.kt b/src/main/kotlin/org/heigit/ohsome/now/statsservice/topic/TopicController.kt
@@ -78,7 +78,7 @@ class TopicController {
         @Parameter(description = "the granularity defined as Intervals in ISO 8601 time format eg: P1M")
         @RequestParam(name = "interval", defaultValue = "P1M", required = false)
         @ParseableInterval
-//        @AtLeastOneMinuteInterval
+        @AtLeastOneMinuteInterval
         interval: String,
 
         @Parameter(description = "A comma separated list of countries, can also only be one country")

diff --git a/src/test/kotlin/org/heigit/ohsome/now/statsservice/topic/TopicControllerMVCTests.kt b/src/test/kotlin/org/heigit/ohsome/now/statsservice/topic/TopicControllerMVCTests.kt
@@ -270,7 +270,6 @@ class TopicControllerMVCTests {
     }
 
 
-    //TODO: check error message
     @Test
     fun `topic stats per interval throws error for interval under one Minute`() {
 
@@ -281,6 +280,8 @@ class TopicControllerMVCTests {
             .queryParam("startdate", "2017-10-01T04:00:00Z")
             .queryParam("enddate", "2020-10-01T04:00:00Z")
             .queryParam("interval", "PT1S")
+            .queryParam("hashtag", "missingmaps")
+
 
         this.mockMvc.perform(GET)
             .andExpect(status().isBadRequest)