12 show banner on dashboard startup when ohsome api is down #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
preparation to upgrade angular from 16 to 17
add alt-attributes to img Elements
anyway start the application, show a temporary unavailability message and the announcement banner Refs: #12
joker234
requested changes
May 3, 2024
| @@ -49,15 +49,15 @@ <h3 class="header">Technology</h3> | |||
| </p> | |||
| <h4 class="header">OSM Quality Analyses are powered by:</h4> | |||
| <div class=""><a href="https://oqt.ohsome.org" target="_blank"> | |||
| <img class="ui image" src="assets/images/ohsome-quality-analyst_without_fonts.svg"> | |||
| <img class="ui image" src="assets/images/ohsome-quality-analyst_without_fonts.svg" alt="ohsome quality analyst logo"> | |||
There was a problem hiding this comment.
Suggested change
| <img class="ui image" src="assets/images/ohsome-quality-analyst_without_fonts.svg" alt="ohsome quality analyst logo"> | |
| <img class="ui image" src="assets/images/ohsome-quality-analyst_without_fonts.svg" alt="ohsome quality API logo"> |
ideally change the svg name as well
There was a problem hiding this comment.
@joker234 what about the Logo itself at the bottom: it shows "ohsome quality analyst". Should we remove it and only write ohsome quality API?
There was a problem hiding this comment.
same issue as GIScience/sketch-map-tool#446
not relevant for this PR
|
joker234
approved these changes
May 6, 2024
mcauer
deleted the
12-show-banner-on-dashboard-startup-when-ohsome-api-is-down
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implemented solution handles the ohsome api downtime now similar to the oqapi downtimes.
In the OSM Hsitory Stats Tab a message about temporary unavailability will appear.
If the ohsome API is down both tabs " OSM Hsitory Stats" and "OSM Quality Analysis" will be disabled.
If there is an announcement from statuscake available it will be displayed additionally to give futher info e.g. about maintenance times.
Besides the issue angular was updated von v16 to v17 and other dependencies as well.