Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#238] Add divert func #236

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

[#238] Add divert func #236

wants to merge 7 commits into from

Conversation

bn-darindouglass-zz
Copy link

@bn-darindouglass-zz bn-darindouglass-zz commented Apr 2, 2020 •
edited

Implements [#238]

Checklist

  • tests
  • updated CHANGELOG (the "unreleased" section)

@bn-darindouglass-zz bn-darindouglass-zz requested a review from a team as a code owner April 2, 2020 20:23
@barracudarin
[FundingCircle#238] Add divert? functions
6580c04 
- This transform should be useful for shunting off bad records to
  failure topics or other quick routing tasks
- `sort-by` allows an arbitrary number of (un)ordered diverting

Signed-off-by: Darin Douglass <ddouglass@barracuda.com>
@barracudarin
[FundingCircle#238] Update CHANGELOG
9b71c24 
Signed-off-by: Darin Douglass <ddouglass@barracuda.com>
@bn-darindouglass-zz bn-darindouglass-zz changed the title Add divert func [#238] Add divert func Apr 2, 2020
@bn-darindouglass-zz
Copy link
Author

bn-darindouglass-zz commented Apr 2, 2020 •
edited

I'm open to suggestions on naming; primarily, I'm not sure if sort-by indicates well enough what it does.

EDIT: nevermind, I just combined the two functions.

@codecov
Copy link

codecov bot commented Apr 2, 2020 •
edited

Codecov Report

Merging #236 (6d1f18f) into master (057ef7c) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #236      +/-   ##
==========================================
+ Coverage   80.05%   80.09%   +0.03%     
==========================================
  Files          42       42              
  Lines        2753     2758       +5     
  Branches      157      157              
==========================================
+ Hits         2204     2209       +5     
  Misses        392      392              
  Partials      157      157
Impacted Files Coverage Δ
src/jackdaw/streams.clj 83.84% <100.00%> (+0.64%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 057ef7c...6d1f18f. Read the comment docs.

@darin-reify darin-reify mentioned this pull request Aug 23, 2022
Open
2 tasks
@darin-reify
Copy link

darin-reify commented Aug 23, 2022 •
edited

this pr has been replaced by this. feel free to close this pr (as i cannot).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bn-darindouglass-zz @darin-reify @barracudarin