-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Forc completions sub commands #5671
base: master
Are you sure you want to change the base?
Conversation
This is the first part of #5612, which will be split into several smaller PRs
Trailing dots are [rejected in fig's main repo](https://github.com/withfig/autocomplete/actions/runs/7978839646/job/21928919907?pr=2280)
Benchmark for 9bde546Click to view benchmark
|
The subcommands may generate completions code optionally. Fixes #5670
7c95355
to
c1d1110
Compare
Benchmark for fbee83aClick to view benchmark
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this needed? Can you give some examples of subcommands that aren't working with the completions before?
We should have some unit tests for this. This could be useful: https://docs.rs/completest/0.0.12/completest/
None of the external subcommand (the plugins) were supported |
Description
Fixes #5670
Add the ability to generate completions for subcommands
Subcommands may generate completions code optionally.
Checklist
Breaking*
orNew Feature
labels where relevant.